Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some tests would be nice #19

Closed
gigabo opened this issue May 31, 2016 · 1 comment
Closed

Some tests would be nice #19

gigabo opened this issue May 31, 2016 · 1 comment
Labels
enhancement

Comments

@gigabo
Copy link
Contributor

gigabo commented May 31, 2016

What's the right granularity? Could go nearly end-to-end and set up a whole lerna repo with commit history. Alternatively could try to pull out just the content generation and test that.
@jamiebuilds
Copy link
Contributor

I would mimic what I set up inside the lerna/lerna repo

@gigabo gigabo mentioned this issue Jun 3, 2016
Merged
emmenko added a commit to emmenko/lerna-changelog that referenced this issue Jan 15, 2017
@emmenko
feat(changelog): allow to output changelog based on tags range
4325524 
This PR mainly introduces a way of querying commits for a custom tags
range (at the moment only commits after the last available tag are taken
into consideration).
Now you can specify a custom range by passing --tagFrom and/or --tagTo
options (--tagTo should be a tag after --tagFrom).
Additionally, as also mentioned in lerna#25, if multiple tags are present
within the custom commits range, they will be grouped together a
changelog entry for each tag will be created.
Basic tests are also present now.

Closes lerna#17,lerna#19,lerna#25
@emmenko emmenko mentioned this issue Jan 15, 2017
Merged
4 tasks
@hzoo hzoo closed this as completed Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gigabo @hzoo @jamiebuilds