Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updates PSL to support IDN TLDs (#2339)
This pull request updates the publicsuffix-go dependency to version 0.3.0, most notably including weppos/publicsuffix-go#40 and support for IDN TLDs. The PA's TestWillingToIssue unit test is updated to confirm that Boulder is WillingToIssue a well formed IDN domain with an IDN TLD. Prior to c5cc328 this causes the PA unit tests to fail as expected with urn:acme:error:malformed :: Name does not end in a public suffix. After c5cc328 everything is 💯 Per CONTRIBUTING.md the unit tests are confirmed to pass: daniel@XXXXXX:~/go/src/github.com/weppos/publicsuffix-go$ git show -s commit 49fe4b0e8276b314e6703300ac26940d9c090a06 Author: Simone Carletti <weppos@weppos.net> Date: Mon Nov 21 19:26:37 2016 +0100 Release 0.3.0 daniel@XXXXXX:~/go/src/github.com/weppos/publicsuffix-go$ go test ./... ? github.com/weppos/publicsuffix-go/cmd/gen [no test files] ? github.com/weppos/publicsuffix-go/cmd/load [no test files] ok github.com/weppos/publicsuffix-go/net/publicsuffix 0.007s ok github.com/weppos/publicsuffix-go/publicsuffix 0.042s :heart: :beer: and :tada:'s to @weppos for the upstream work required for this fix. We truly appreciate your volunteer work on the PSL and the publicsuffix-go library. You're the best! This resolves #2277.
- Loading branch information