Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates PSL to support IDN TLDs #2339

Merged
merged 3 commits into from
Nov 21, 2016
Merged

Updates PSL to support IDN TLDs #2339

merged 3 commits into from
Nov 21, 2016

Conversation

cpu
Copy link
Contributor

@cpu cpu commented Nov 21, 2016

This pull request updates the publicsuffix-go dependency to version 0.3.0, most notably including weppos/publicsuffix-go#40 and support for IDN TLDs.

The PA's TestWillingToIssue unit test is updated to confirm that Boulder is WillingToIssue a well formed IDN domain with an IDN TLD. Prior to c5cc328 this causes the PA unit tests to fail as expected with urn:acme:error:malformed :: Name does not end in a public suffix. After
c5cc328 everything is 💯

Per CONTRIBUTING.md the unit tests are confirmed to pass:

daniel@XXXXXX:~/go/src/github.com/weppos/publicsuffix-go$ git show -s
commit 49fe4b0e8276b314e6703300ac26940d9c090a06
Author: Simone Carletti <weppos@weppos.net>
Date:   Mon Nov 21 19:26:37 2016 +0100

    Release 0.3.0

daniel@XXXXXX:~/go/src/github.com/weppos/publicsuffix-go$ go test ./...
?   	github.com/weppos/publicsuffix-go/cmd/gen	[no test files]
?   	github.com/weppos/publicsuffix-go/cmd/load	[no test files]
ok  	github.com/weppos/publicsuffix-go/net/publicsuffix	0.007s
ok  	github.com/weppos/publicsuffix-go/publicsuffix	0.042s

❤️ 🍺 and 🎉's to @weppos for the upstream work required for this fix. We truly appreciate your volunteer work on the PSL and the publicsuffix-go library. You're the best!

This resolves #2277.

Daniel added 2 commits November 21, 2016 08:49
This commit bumps the publicsuffix-go dependency to the WIP branch from
weppos/publicsuffix-go#40 to support IDN TLDs.
@cpu cpu mentioned this pull request Nov 21, 2016
@cpu
Copy link
Contributor Author

cpu commented Nov 21, 2016

IDN TLD PR was merged upstream - when there's a release tag cut I'll update this PR and we'll be ready to merge.

@weppos
Copy link
Contributor

weppos commented Nov 21, 2016

@cpu I tagged v0.3.0 and signed the commit as expected.
https://github.com/weppos/publicsuffix-go/releases/tag/v0.3.0

@cpu
Copy link
Contributor Author

cpu commented Nov 21, 2016

@weppos that was fast! Thanks!

@rolandshoemaker rolandshoemaker merged commit 8b7a6b3 into master Nov 21, 2016
@cpu cpu deleted the cpu-idn-psl branch April 5, 2017 19:38
@cpu cpu mentioned this pull request May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PA rejects domains ending in IDN TLD
4 participants