Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
publicsuffix-go
dependency to version 0.3.0, most notably including weppos/publicsuffix-go#40 and support for IDN TLDs.The PA's
TestWillingToIssue
unit test is updated to confirm that Boulder isWillingToIssue
a well formed IDN domain with an IDN TLD. Prior to c5cc328 this causes the PA unit tests to fail as expected withurn:acme:error:malformed :: Name does not end in a public suffix
. Afterc5cc328 everything is 💯
Per
CONTRIBUTING.md
the unit tests are confirmed to pass:❤️ 🍺 and 🎉's to @weppos for the upstream work required for this fix. We truly appreciate your volunteer work on the PSL and the publicsuffix-go library. You're the best!
This resolves #2277.