Fixes the signature of setup to not require an argument #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philolo1
commented
Sep 12, 2023
| [6] = '6', -- '₆', | ||
| [7] = '7', -- '₇', | ||
| [8] = '8', -- '₈', | ||
| [9] = '9', -- '₉', |
There was a problem hiding this comment.
these changes are done by my lua formatter
There was a problem hiding this comment.
In general, avoid introducing changes by your personal formatter onto other repositories with a different style.
We can let this one in.
philolo1
force-pushed
the
feature/fix-signature-setup
branch
from
948e525
to
91e2544
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the signature of setup to allow now parameters (nil).
Otherwise I would get an error: