Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the signature of setup to not require an argument #876

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fixes the signature of setup to not require an argument #876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lua/gitsigns.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ end
--- Attributes: ~
--- {async}
---
--- @param cfg table Configuration for Gitsigns.
--- @param cfg table|nil Configuration for Gitsigns.
--- See |gitsigns-usage| for more details.
M.setup = void(function(cfg)
gs_config.build(cfg)
Expand Down
20 changes: 10 additions & 10 deletions lua/gitsigns/config.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,15 +442,15 @@ M.schema = {
count_chars = {
type = 'table',
default = {
[1] = '1', -- '₁',
[2] = '2', -- '₂',
[3] = '3', -- '₃',
[4] = '4', -- '₄',
[5] = '5', -- '₅',
[6] = '6', -- '₆',
[7] = '7', -- '₇',
[8] = '8', -- '₈',
[9] = '9', -- '₉',
[1] = '1', -- '₁',
[2] = '2', -- '₂',
[3] = '3', -- '₃',
[4] = '4', -- '₄',
[5] = '5', -- '₅',
[6] = '6', -- '₆',
[7] = '7', -- '₇',
[8] = '8', -- '₈',
[9] = '9', -- '₉',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes are done by my lua formatter

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, avoid introducing changes by your personal formatter onto other repositories with a different style.

We can let this one in.

['+'] = '>', -- '₊',
},
description = [[
Expand Down Expand Up @@ -855,7 +855,7 @@ local function handle_deprecated(cfg)
end
end

--- @param user_config Gitsigns.Config
--- @param user_config Gitsigns.Config|nil
function M.build(user_config)
user_config = user_config or {}

Expand Down