-
Notifications
You must be signed in to change notification settings - Fork 121
Replaced use of ltrim as it doesn't work as intended. #292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just had this issue. I realized the problem was using the ltrim
, with nearly identical alias and field values. I ended up with the very same preg_replace
code that @ianwilk52 provides in this PR, and it works fine :)
i too had this issue. it was timeconsuming to find the reason. |
Thx 👍 |
I have revert the PR cause break all tests. |
because im interestet in reasons for the braking tests i tried installing the last set of dependencies (copiing from the travis output of the test from 5.0.7) and get exact the same errors. how is this possible? even my local php install is minimum that age. |
Ahh i found it the hard coded year 2013 in the test is invalid because the symfony default is: |
…lexik#292)" (lexik#301)" This reverts commit 25f5b77.
ltrim removes everything until a character not in the map is encountered, by the looks of it, only "{$rootPart->getAlias()}." should be removed.