Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Revert "Revert "Replaced use of ltrim as it doesn't work as intended."" #314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ph538834
Copy link

@ph538834 ph538834 commented May 7, 2019

Reverts #301
Now that the reason for the revert is gone(fixed date in tests) can we reapply this?

@ph538834 ph538834 marked this pull request as ready for review May 7, 2019 15:53
@ph538834
Copy link
Author

ph538834 commented May 7, 2019

original pr from @ianwilk52
#292

@codeTom
Copy link

codeTom commented Dec 9, 2020

Given that the test issue has now been resolved, can this be merged?

@rtreffler-goldcore
Copy link

rtreffler-goldcore commented Oct 20, 2021

this is still an issue, can we merge it ?
@Spike31 is there additional work needed to merge it ?

@gilles-g
Copy link
Member

Hi @rtreffler-goldcore,

I'm not sure to know where is your problem, could you add some tests?

@rtreffler-goldcore
Copy link

rtreffler-goldcore commented Oct 21, 2021

Hi @rtreffler-goldcore,

I'm not sure to know where is your problem, could you add some tests?

This is something that was once merged by you (#292 (comment)), the bug I've discovered while debugging other situation.

The way $fieldName is derived is not correct, then later it fails to inspect $metadata->associationMappings[$fieldName].
In my case alias for a table was pd and association was called product as a result $fieldName results to roduct.
image

Ill try to add tests later during the day if the above explanation is not sufficient.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants