Patch for EVE ver 8.5.1 #2715
Merged
Patch for EVE ver 8.5.1 #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should set cgroup limits for all services Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com> (cherry picked from commit e5bb6ce)
Moving to the second instance of containerd require enlarge of cgroups limit, seems we miss enlarge of /eve/containerd Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com> (cherry picked from commit 7ec7e84)
We fill devSourceBytes with various sources and should cleanup it Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com> (cherry picked from commit 36f9b78)
Unbounded read into memory may hit problem, let limit reader with reasonable size. Instead of loading file into memory we can use line-by-line approach to read collected logs and gzip them. Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com> (cherry picked from commit f22d648)
To not consume memory for the content of the directory we should read several files and iterate over them, not over the whole directory. This commit also includes improvements for newlogd to not store unnecessary file path and to adjust limit for number of files inside directories based on size limit and expected max size of file. Without this limit we may go into enormous file count. Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com> (cherry picked from commit 686a8fb)
Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com> (cherry picked from commit 55a9d70)
We cannot use disk.Usage for persist in case of zfs since the mounted /persist does not indicate usage of zvols and snapshots. Let's use information from zfs. Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com> (cherry picked from commit f114d41)
Seems we are covered by the problem described here: anatol/smart.go#6. lsof indicates lots of open sda9 in case of zfs from zedbox. Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com> (cherry picked from commit 4e9eccb)
We should use information from zfs to calculate usage of /persist/vault/volumes as we use zvol devices not placed in that directory. We should use LogicalUsed to have the same behaviour as for ext4 where we do not calculate empty blocks of qcow2. Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com> (cherry picked from commit 5995553)
We expect error "Remaining disk space ... volume needs ..." in case of no space for new volume, but I see this error for several seconds. Seems it was silently hidden by "Error creating zfs zvol at ..., error=exit status 1, output=cannot create '...': out of space" which is not expected. Seems we should move check for space into our volume state handler function (doUpdateVol). Also this commit adds simple retry in case of delete of another volume. Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com> (cherry picked from commit 0659e3b)
ghost
requested review from
Merged
milan-zededa
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains:
#2678
#2699
#2707
#2708