Unit-tests fixes #2717
Merged
Unit-tests fixes #2717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems we have problem with workerpool test as GC may run or not run in the background in time of check for workers count. Let's spread the test work in time and add sleep according to GC intervals. Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
We should not use current directory for pubsub in test as it will be mounted and we potentially (for example on MacOS) will not have possibility to use sockets there. Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
We use pci addresses in tests and potentially can intersect with HW which is not expected, i.e. I can see errors in TestCreateDomConfig/amd64-fml and TestPciLongExists when I have 03:00.0 on device. Let's try to avoid it using bus number from the end of possible values. Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
milan-zededa
approved these changes
Jul 14, 2022
ghost
self-requested a review
ghost
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several fixes for unit tests:
the background in time of check for workers count. Let's spread the test
work in time and add sleep according to GC intervals.
mounted and we potentially (for example on MacOS) will not have
possibility to use sockets there
which is not expected, i.e. I can see errors in
TestCreateDomConfig/amd64-fml and TestPciLongExists when I have 03:00.0
on device. Let's try to avoid it using bus number from the end of
possible values.