Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly set go modules in case running in GOPATH #34

Merged
merged 2 commits into from
May 22, 2019
Merged

explicitly set go modules in case running in GOPATH #34

merged 2 commits into from
May 22, 2019

Conversation

deitch
Copy link
Contributor

@deitch deitch commented May 22, 2019 •
edited
Loading

Signed-off-by: Avi Deitcher avi@deitcher.net

Fixes #33

This way, can run make (or make all or make build) whether in GOPATH or not.

@deitch
explicitly set go modules in case running in GOPATH
f176111 
Signed-off-by: Avi Deitcher <avi@deitcher.net>
@deitch
Copy link
Contributor Author

deitch commented May 22, 2019

cc @eriknordmark @rvs

@rvs
Copy link
Contributor

rvs commented May 22, 2019

LGTM

@deitch
Copy link
Contributor Author

deitch commented May 22, 2019

Go ahead and merge it, @rvs ?

@rvs rvs merged commit bc15a57 into lf-edge:master May 22, 2019
@deitch deitch deleted the explicit-go-mod branch May 22, 2019 20:07
@andrewd-zededa andrewd-zededa mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GO111MODULE needs to be set when building pillar
2 participants
@deitch @rvs