Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix openssh build #4073

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Fix openssh build #4073

merged 1 commit into from
Jul 10, 2024

Conversation

andrewd-zededa
Copy link
Contributor

removed duplicate add

@andrewd-zededa andrewd-zededa marked this pull request as ready for review July 9, 2024 22:01
@andrewd-zededa andrewd-zededa requested a review from rouming as a code owner July 9, 2024 22:01
@github-actions github-actions bot requested a review from eriknordmark July 9, 2024 22:01
eriknordmark
eriknordmark approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot requested a review from eriknordmark July 9, 2024 23:59
@andrewd-zededa
Copy link
Contributor Author

@eriknordmark I bumped the build by adding a small change to disable the openssh rekey test which was taking over 30min to run locally.

@milan-zededa
Copy link
Contributor

I see this build error:

Error: error building "lfedge/eve-debug:dfd4456a0f41cfea7577a264976b6cf55e6882a4": error building for arch amd64: failed to solve: process "/bin/sh -c gpg --verify openssh-${OPENSSH_VERSION}.tar.gz.asc openssh-${OPENSSH_VERSION}.tar.gz" did not complete successfully: exit code: 2
2024/07/10 00:03:49 error during command execution: error building "lfedge/eve-debug:dfd4456a0f41cfea7577a264976b6cf55e6882a4": error building for arch amd64: failed to solve: process "/bin/sh -c gpg --verify openssh-${OPENSSH_VERSION}.tar.gz.asc openssh-${OPENSSH_VERSION}.tar.gz" did not complete successfully: exit code: 2

@christoph-zededa
Copy link
Contributor

I see this build error:

Error: error building "lfedge/eve-debug:dfd4456a0f41cfea7577a264976b6cf55e6882a4": error building for arch amd64: failed to solve: process "/bin/sh -c gpg --verify openssh-${OPENSSH_VERSION}.tar.gz.asc openssh-${OPENSSH_VERSION}.tar.gz" did not complete successfully: exit code: 2
2024/07/10 00:03:49 error during command execution: error building "lfedge/eve-debug:dfd4456a0f41cfea7577a264976b6cf55e6882a4": error building for arch amd64: failed to solve: process "/bin/sh -c gpg --verify openssh-${OPENSSH_VERSION}.tar.gz.asc openssh-${OPENSSH_VERSION}.tar.gz" did not complete successfully: exit code: 2

The pipeline behaves strange:

#36 [build 21/56] WORKDIR /usr/src/openssh-9.8p1
#36 DONE 0.0s

#37 [build 22/56] ADD https://cdn.openbsd.org/pub/OpenBSD/OpenSSH/portable/openssh-9.8p1.tar.gz /usr/src
#37 DONE 0.0s

#38 [build 23/56] ADD https://cdn.openbsd.org/pub/OpenBSD/OpenSSH/portable/openssh-9.8p1.tar.gz.asc /usr/src
#38 DONE 0.0s

#39 [build 24/56] COPY ssh/RELEASE_KEY.asc /usr/src
#39 DONE 0.0s

(https://github.com/lf-edge/eve/actions/runs/9865821631/job/27243476619?pr=4073 )

but according to the code in this PR WORKDIR /usr/src/openssh-9.8p1 comes after ADD .../openssh-${OPENSSH_VERSION}.tar.gz.asc (https://github.com/lf-edge/eve/pull/4073/files#diff-eb8b8d5cc8d10e1bd74ad66ca8bb1565b32a21a18220ef586c0a22d2e961aee1L77 )

@milan-zededa
Copy link
Contributor

@andrewd-zededa Please rebase onto the latest master. It should fix the failing build.

@andrewd-zededa
Copy link
Contributor Author

@milan-zededa rebased on latest

@andrewd-zededa
Copy link
Contributor Author

and Rate limited...

429 Too Many Requests - Server message: toomanyrequests

@andrewd-zededa
Copy link
Contributor Author

The build error is odd see steps 34, 35, 36 below which are the lines removed by the pr.

#33 [build 18/56] WORKDIR /usr/src
#33 DONE 0.0s

#34 [build 19/56] ADD https://cdn.openbsd.org/pub/OpenBSD/OpenSSH/portable/openssh-9.8p1.tar.gz /usr/src
#34 DONE 0.0s

#35 [build 20/56] RUN tar xvf openssh-9.8p1.tar.gz
#0 0.023 openssh-9.8p1
...
...
...
#35 0.171 openssh-9.8p1/xmss_wots.h
#35 DONE 0.2s

#36 [build 21/56] WORKDIR /usr/src/openssh-9.8p1
#36 DONE 0.0s

#37 [build 22/56] ADD https://cdn.openbsd.org/pub/OpenBSD/OpenSSH/portable/openssh-9.8p1.tar.gz /usr/src
#37 DONE 0.0s

#38 [build 23/56] ADD https://cdn.openbsd.org/pub/OpenBSD/OpenSSH/portable/openssh-9.8p1.tar.gz.asc /usr/src
#38 DONE 0.0s
Error: error building "lfedge/eve-debug:dfd4456a0f41cfea7577a264976b6cf55e6882a4": error building for arch amd64: failed to solve: process "/bin/sh -c gpg --verify openssh-${OPENSSH_VERSION}.tar.gz.asc openssh-${OPENSSH_VERSION}.tar.gz" did not complete successfully: exit code: 2
2024/07/10 16:14:58 error during command execution: error building "lfedge/eve-debug:dfd4456a0f41cfea7577a264976b6cf55e6882a4": error building for arch amd64: failed to solve: process "/bin/sh -c gpg --verify openssh-${OPENSSH_VERSION}.tar.gz.asc openssh-${OPENSSH_VERSION}.tar.gz" did not complete successfully: exit code: 2
make: *** [Makefile:1035: eve-debug] Error 1
Error: Process completed with exit code 2.

@andrewd-zededa
Copy link
Contributor Author

Added a GH actions fix attempt by @christoph-zededa, watching it now.

@andrewd-zededa
Fix openssh build
cd64d91 
removed duplicate add

Signed-off-by: Andrew Durbin <andrewd@zededa.com>
@eriknordmark
Copy link
Contributor

We know this fix is needed since without it we can't even do a make pkg/debug in a workspace.
Merging.
But we might also need some workflow/actions fixes - I don't know.

@eriknordmark eriknordmark merged commit 85f981b into lf-edge:master Jul 10, 2024
10 checks passed
@andrewd-zededa andrewd-zededa mentioned this pull request Jul 10, 2024
Merged
@eriknordmark eriknordmark added the stable Should be backported to stable release(s) label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christoph-zededa christoph-zededa christoph-zededa approved these changes

@milan-zededa milan-zededa milan-zededa approved these changes

@rouming rouming Awaiting requested review from rouming rouming is a code owner

@eriknordmark eriknordmark Awaiting requested review from eriknordmark

Assignees
No one assigned
Labels
stable Should be backported to stable release(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewd-zededa @milan-zededa @christoph-zededa @eriknordmark