-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edgeview App needs latest pillar vendor files #3536
Edgeview App needs latest pillar vendor files #3536
Conversation
naiming-zededa
commented
Oct 26, 2023
- import the latest changes in zedroutertypes.go for app IP display to work
- fix an issue of single instance JWT file but user specifying instance number > 1
Signed-off-by: Naiming Shen <naiming@zededa.com>
…y name change Signed-off-by: Naiming Shen <naiming@zededa.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3536 +/- ##
==========================================
+ Coverage 20.50% 20.51% +0.01%
==========================================
Files 208 208
Lines 45381 45381
==========================================
+ Hits 9307 9312 +5
+ Misses 35392 35387 -5
Partials 682 682
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Is the missing instid > 1 check a regression from earlier? I'm asking to determine whether this is something we should consider backporting to stable releases.
I think we should also backport this to 11.0 (if it is going to be stable release). Otherwise app command will not work in that particular version due to underlay renaming. |
this thing has been there for quite a while. I only saw this issue with debug Andrew's problem starting a tcp session. I don't think this is a big deal. |
if needed, sure. May be this is ok, since we'll make the LTS for version 11 later, and that is more people will use. |