Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0-stable] Edgeview backport from EVE PR #3536 #3850

Merged

Conversation

naiming-zededa
Copy link
Contributor

@naiming-zededa naiming-zededa commented Apr 10, 2024

back port patch from PR #3536 on edgeview fix into 11.0.5

Signed-off-by: Naiming Shen <naiming@Admins-MacBook-Pro-3.local>
…y name change

Signed-off-by: Naiming Shen <naiming@Admins-MacBook-Pro-3.local>
@naiming-zededa naiming-zededa force-pushed the naiming-edgeview-11.0.5-lts branch from 0813891 to 87b4a29 Compare April 11, 2024 07:43
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why backport the kubevirt support? I thought there was an earlier PR which fixed the API/struct difference with pkg/pillar which needed to be backported.

@naiming-zededa naiming-zededa changed the title Edgeview backport from EVE PR #3844 Edgeview backport from EVE PR #3536 Apr 12, 2024
@naiming-zededa
Copy link
Contributor Author

@eriknordmark, sorry, i typed in title the number wrong, it should be this one: #3536

@eriknordmark eriknordmark changed the title Edgeview backport from EVE PR #3536 [11.0-stable] Edgeview backport from EVE PR #3536 Apr 13, 2024
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit 3625ee1 into lf-edge:11.0-stable Apr 18, 2024
41 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants