Debugging Volume Creation Post-Reboot through Enhanced Logging #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ules. This commit introduces additional logging warnings in the baseosmgr, downloader, volumemgr, and related modules. The added warnings are triggered when there is an unexpected change in the total size of a blob, specifically when the total size is altered from a non-zero value to a different non-zero value. Signed-off-by: Nikolay Martyanov <nikolay@zededa.com>
This commit adds a log entry in the `CtrGetImage` function to record exceptions encountered during the verification of the containerd client. Additionally, it introduces warning logs in the `verifyCtr` function to report when the Containerd context is in an error state. These enhancements aim to improve the visibility and traceability of errors related to client verification and context handling in containerd operations. Signed-off-by: Nikolay Martyanov <nikolay@zededa.com>
This commit introduces multiple logging enhancements across various functions in the volumemgr module to improve the tracking of ContentFormat setting in VolumeStatus. Key changes include: - Logging the setting of ContentFormat in handleDeferredVolumeCreate(), indicating when the content format is set based on the volume's key. - Adding logs in populateExistingVolumesFormatObjects() to record the saving of volume format for each volume. - In getVolumeStatusByLocation(), enhanced logging is added to parse the format from the location, indicate the found format, and log the format as a digit. Additionally, a log entry is added to confirm the found volume and its content format. - doUpdateVol() now includes logs for creating a blank volume with a specific format and setting the VolumeStatus.ContentFormat based on the ContentTree. These enhancements aim to provide clearer insights into the process of setting and updating the ContentFormat in VolumeStatus, facilitating better debugging and monitoring of volume management operations. Signed-off-by: Nikolay Martyanov <nikolay@zededa.com>
OhmSpectator
requested review from
deitch and
eriknordmark
and removed request for
rvs and
eriknordmark
deitch
approved these changes
Dec 13, 2023
I am interested in the concept of simplified debugging through the decoupling of Pillar. How exactly do you see it? |
|
It isn't the right place to discuss it. Let's set up a conversation around it offline. |
I would prefer to have it documented somewhere... That's why I thought it could be a good place. But ok, let's discuss it in any other way you prefer =) |
eriknordmark
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
This is fine with me.
An alternative would be to move some of these (like the change to TotalSize from some non-zero value) into the LogModify function for VolumeStatus, but that wouldn't capture which code did the modification. And it wouldn't help with tracking down how ContentType is set/changed.
So let's go with these changes as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request encompasses a series of commits aimed at addressing a potential issue with volume creation following a system reboot. These changes primarily revolve around enhancing logging mechanisms in various modules, with a particular focus on the volumemgr module. By improving the clarity and detail of logs, this PR seeks to facilitate easier identification and resolution of issues related to volume management post-reboot.