Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.4-stable] Debugging Volume Creation Post-Reboot through Enhanced Logging #3672

Conversation

OhmSpectator
Copy link
Member

It's a backport of #3666, which was initially introduced in 9.4-stable.

…ules.

This commit introduces additional logging warnings in the baseosmgr,
downloader, volumemgr, and related modules. The added warnings are triggered
when there is an unexpected change in the total size of a blob, specifically
when the total size is altered from a non-zero value to a different non-zero
value.

Signed-off-by: Nikolay Martyanov <nikolay@zededa.com>
(cherry picked from commit c659aa5)
This commit adds a log entry in the `CtrGetImage` function to record exceptions
encountered during the verification of the containerd client. Additionally, it
introduces warning logs in the `verifyCtr` function to report when the
Containerd context is in an error state. These enhancements aim to improve the
visibility and traceability of errors related to client verification and
context handling in containerd operations.

Signed-off-by: Nikolay Martyanov <nikolay@zededa.com>
(cherry picked from commit 336075a)
This commit introduces multiple logging enhancements across various functions
in the volumemgr module to improve the tracking of ContentFormat setting in
VolumeStatus.

Key changes include:

- Logging the setting of ContentFormat in handleDeferredVolumeCreate(),
  indicating when the content format is set based on the volume's key.

- Adding logs in populateExistingVolumesFormatObjects() to record the saving of
  volume format for each volume.

- In getVolumeStatusByLocation(), enhanced logging is added to parse the format
  from the location, indicate the found format, and log the format as a digit.
  Additionally, a log entry is added to confirm the found volume and its content
  format.

- doUpdateVol() now includes logs for creating a blank volume with a specific
  format and setting the VolumeStatus.ContentFormat based on the ContentTree.

These enhancements aim to provide clearer insights into the process of setting
and updating the ContentFormat in VolumeStatus, facilitating better debugging
and monitoring of volume management operations.

Signed-off-by: Nikolay Martyanov <nikolay@zededa.com>
(cherry picked from commit 5a06e79)
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark eriknordmark merged commit 3e63dda into lf-edge:10.4-stable Dec 15, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants