Small bug fixes related to cellular connectivity #3926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without cellular configuration (APN, etc.), any attempt to connect through wwan interfaces will always fail. Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
changed the title
rene
reviewed
May 21, 2024
rene
reviewed
May 21, 2024
I have seen cases where modem would not report SIM card type (the returned value was not specified), even though the (physical) SIM card was inserted. If SIM card type is not known, we can instead determine the card presence based on the ICCID number availability. Moreover, when ModemManager is unable to recognize the SIM card type, EVE would report the type as SimTypePhysical. This is clearly incorrect, SimTypeUnspecified should be reported instead. Signed-off-by: Milan Lenco <milan@zededa.com>
Instead the password should be masked and replaced with e.g. asterisks. Signed-off-by: Milan Lenco <milan@zededa.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 commits in this PR:
Exclude cellular ports from the last-resort config
Without cellular configuration (APN, etc.), any attempt to connect
through wwan interfaces will always fail.
Do not assume that SIM is absent if its type is not known
I have seen cases where modem would not report SIM card type
(the returned value was not specified), even though the (physical)
SIM card was inserted.
If SIM card type is not known, we can instead determine the card
presence based on the ICCID number availability.
Moreover, when ModemManager is unable to recognize the SIM card type,
EVE would report the type as SimTypePhysical. This is clearly
incorrect, SimTypeUnspecified should be reported instead.
Do not log user password in clear text
Instead the password should be masked and replaced with e.g. asterisks.