Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0 stable] Backport all recent wwan improvements #3943

Merged
merged 10 commits into from
May 28, 2024

Conversation

milan-zededa
Copy link
Contributor

With modern high-speed 4G and 5G modems, it is more and more common
to connect the modem over the PCIe bus instead of USB bus. PCIe offers
higher speed, lower latency and lower power consumption than
USB equivalent, making it perfectly suitable for 5G high speed
requirements (up to 20Gbps).

To support PCIe modems, we first had to enable all kernel modules
related to the Qualcomm Modem-Host Interface (MHI), which was done in
the eve-kernel repo, e.g.: lf-edge/eve-kernel#91

Next, some improvements were necessary in the mmagent to support
referencing modems by the PCI address (instead of USB address). This,
together with a documentation update, is done in this commit.

Signed-off-by: Milan Lenco <milan@zededa.com>
(cherry picked from commit 923acb5)
Signed-off-by: Milan Lenco <milan@zededa.com>
(cherry picked from commit 13b2c56)
Signed-off-by: Milan Lenco <milan@zededa.com>
(cherry picked from commit 2d660b2)
Signed-off-by: Milan Lenco <milan@zededa.com>
(cherry picked from commit 7f6b1ad)
If the user does not select a specific SIM slot, EVE will utilize
whichever SIM slot is already designated as primary (e.g., by the device
manufacturer).
However, there is one exception: if the primary SIM is an eSIM
(virtual embedded SIM), EVE will default to using the first physical
slot instead, as eSIM is not supported. EVE will attempt to connect
(and fail) with the eSIM only if the user explicitly selects the eSIM
slot.

Signed-off-by: Milan Lenco <milan@zededa.com>
(cherry picked from commit a7d23ef)
This tool is able to perform FCC unlock procedure on devices:
* ThinkEdge SE30 with modem Quectel EM160
* ThinkEdge SE10 with modem Quectel EM05-G

Signed-off-by: Milan Lenco <milan@zededa.com>
(cherry picked from commit 2e935ae)
This newer version includes an OSS-friendly License.

Signed-off-by: Milan Lenco <milan@zededa.com>
(cherry picked from commit 0060b5b)
Without cellular configuration (APN, etc.), any attempt to connect
through wwan interfaces will always fail.

Signed-off-by: Milan Lenco <milan@zededa.com>
(cherry picked from commit 3a20819)
I have seen cases where modem would not report SIM card type
(the returned value was not specified), even though the (physical)
SIM card was inserted.
If SIM card type is not known, we can instead determine the card
presence based on the ICCID number availability.

Moreover, when ModemManager is unable to recognize the SIM card type,
EVE would report the type as SimTypePhysical. This is clearly
incorrect, SimTypeUnspecified should be reported instead.

Signed-off-by: Milan Lenco <milan@zededa.com>
(cherry picked from commit b5bc796)
Instead the password should be masked and replaced with e.g. asterisks.

Signed-off-by: Milan Lenco <milan@zededa.com>
(cherry picked from commit 0483f48)
Copy link
Contributor

@eriknordmark eriknordmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eriknordmark
Copy link
Contributor

Given the test failures due to infra issues we need to make sure this gets tested manually. We have another set of backports so can do that with multiple PRs added to 12.0

@eriknordmark eriknordmark merged commit ac560f4 into lf-edge:12.0 May 28, 2024
19 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants