Testing and Integrating new qemu_thread_set_affinity definition #4212

roja-zededa · 2024-09-04T17:57:25Z

Xentools 4.19.0 which uses QEMU 8.0.4 has new implementation for CPU pinning. A big difference between our implementation and the QEMU vanilla version is that our implementation can pin vCPU-to-pCPU 1-to-1, while the QEMU implementation allows only a set of CPUs to be assigned to an entire VM (and the VM's vCPU threads can still migrate among the given set of pCPUs). Need to verify and intergrate if the new qemu_thread_set_affinity definition is suitable for our use case

OhmSpectator · 2024-09-04T20:11:05Z

The most critical use case for the new CPU pinning is realtime, as this implementation does not really pin CPUs. I would switch to it if it does not worsen the results of RT tests. @rouming can provide more information, how he performed the testing.

Also, if using the native qemu implementation, the qemu parameters should be used in native way, as well. You can find it in the PR I shared with you earlier: rucoder#1

roja-zededa · 2024-09-16T20:00:04Z

The most critical use case for the new CPU pinning is realtime, as this implementation does not really pin CPUs. I would switch to it if it does not worsen the results of RT tests. @rouming can provide more information, how he performed the testing.

Also, if using the native qemu implementation, the qemu parameters should be used in native way, as well. You can find it in the PR I shared with you earlier: rucoder#1

@rouming Could you please provide more info on RT CPU Pinning tests?

rouming · 2024-09-16T20:57:00Z

The most critical use case for the new CPU pinning is realtime, as this implementation does not really pin CPUs. I would switch to it if it does not worsen the results of RT tests. @rouming can provide more information, how he performed the testing.
Also, if using the native qemu implementation, the qemu parameters should be used in native way, as well. You can find it in the PR I shared with you earlier: rucoder#1

@rouming Could you please provide more info on RT CPU Pinning tests?

The RT suite is here: https://git.kernel.org/pub/scm/utils/rt-tests/rt-tests.git/ , the standard de facto is cyclictest, you can search how to use it if you wish, but I can tell in advance, that pinning the whole process with all its thread to set of cpus comparing to 1to1 mapping has no visible impact on any test results, just because scheduler is smart enough and wont perform a task migration to another cpu if load on all vcpus is equal (usually this is the case). even if task migrates, that does not happen frequently, so impact is misarable.

OhmSpectator · 2024-09-16T21:41:07Z

It would be nice to remove the custom patches in this case.

But I don't see how the QEMU vanilla pinning is used here? To run with the native CPU pinning, QEMU should start with -object thread-context,id=tc1,cpu-affinity=0-1,cpu-affinity=6-7 option or similar...

rouming · 2024-09-17T11:45:05Z

@roja-zededa I see this PR contains the commit message from another PR "Upgraded Xen-tools from 4.15 to 4.19.0", not sure what is the purpose of duplicating these if this is not a mistake.

roja-zededa · 2024-09-17T17:35:26Z

@roja-zededa I see this PR contains the commit message from another PR "Upgraded Xen-tools from 4.15 to 4.19.0", not sure what is the purpose of duplicating these if this is not a mistake.

@rouming No, it wasn't a duplicate. Upgrading xentool version to 4.19.0 introduced a new vanilla qemu pinning feature from QEMU 8.0, we're testing here if we need to keep the vanilla pinning feature or go with Nikolay's 1-1 custom pinning patch which is already included in the previous xentools versions.

rouming · 2024-09-18T06:08:41Z

@roja-zededa I see this PR contains the commit message from another PR "Upgraded Xen-tools from 4.15 to 4.19.0", not sure what is the purpose of duplicating these if this is not a mistake.

@rouming No, it wasn't a duplicate. Upgrading xentool version to 4.19.0 introduced a new vanilla qemu pinning feature from QEMU 8.0, we're testing here if we need to keep the vanilla pinning feature or go with Nikolay's 1-1 custom pinning patch which is already included in the previous xentools versions.

Now I see you pushed a commit which corresponds to the PR description, nice.

Can you please share what are the results of testing and how exactly do you test two different implementations.

OhmSpectator · 2024-10-01T20:50:07Z

I would just cherry-pick the original commit and save the commit message.

git remote add ohmspectator git@github.com:OhmSpectator/eve.git
git fetch ohmspectator
git cherry-pick 32ec62b016016792d2c07512428f2e50559e7c34

OhmSpectator · 2024-10-16T10:51:27Z

@roja-zededa, any progress on manual testing?

roja-zededa · 2024-10-16T17:06:18Z

qemu_thread_set_affinity(cpu->thread, NULL, cpu->cpumask); definition has been changed in the newer version. As of now, passing NULL for CPUlist but that might cause some issues. Need to change patch 15 to accommodate the new definition.

OhmSpectator · 2024-10-16T17:14:56Z

qemu_thread_set_affinity(cpu->thread, NULL, cpu->cpumask); definition has been changed in the newer version. As of now, passing NULL for CPUlist but that might cause some issues. Need to change patch 15 to accommodate the new definition.

I would make it as a new patch without changing patch 15.

roja-zededa · 2024-10-16T18:46:38Z

@OhmSpectator The board I have right now doesn't have 10 cores. Would it be okay to manually perform the test on a four-core DellOptiplex? If that doesn't work we can directly kickoff the new cpupinning test desgined by vignesh.

OhmSpectator · 2024-10-16T19:22:04Z

You can also run EVE in QEMU with a given amount of VCPUs =)

Update pillar's handling of QEMU guests to take advantage of native CPU pinning options introduced in the newer version of QEMU (8.0.4). This eliminates the need for our custom patches to QEMU for CPU pinning. The following changes are included: Removing custom qemu cpu-pinning patches to include the native qemu-pinning feature (1) Refactoring CPU pinning to use integer slices instead of comma-separated strings (2) Updating QEMU command-line arguments to include native CPU pinning options (3) Ensuring compatibility with both KVM and Xen hypervisors (4) This change allows us to leverage upstream QEMU improvements and simplifies the codebase by removing custom patches and complex string manipulations. Tested with QEMU version 8.0.4 Signed-off-by: Roja Eswaran <roja@zededa.com>

roja-zededa · 2024-10-23T20:15:52Z

@OhmSpectator Tested this PR with tiny VM (1vcpu). Here are the results. Added a VM (no pin), 3 more VMs with pinning enabled.
79e8a31a-712c-4d1a-be9d-1f41a6da1300:~# for pid in $(pgrep qemu) ; do echo "======= QEMU $pid threads: =======" ; for spid in $(ps -T -o spid= -p "$pid" )
; do taskset -pc "$spid" ; done ;

done
======= QEMU 32076 threads: =======
pid 32076's current affinity list: 0-3
pid 32094's current affinity list: 0-3
pid 32098's current affinity list: 0-3
pid 32099's current affinity list: 0-3
pid 32101's current affinity list: 0-3
pid 32142's current affinity list: 0-3
pid 32211's current affinity list: 0-3
pid 32444's current affinity list: 0-3
pid 32445's current affinity list: 0-3
pid 32446's current affinity list: 0-3
pid 32447's current affinity list: 0-3
pid 32448's current affinity list: 0-3
pid 32449's current affinity list: 0-3

79e8a31a-712c-4d1a-be9d-1f41a6da1300:~# for pid in $(pgrep qemu) ; do echo "======= QEMU $pid threads: =======" ; for spid in $(ps -T -o spid= -p "$pid" )
; do taskset -pc "$spid" ; done ;

done
======= QEMU 578 threads: =======
pid 578's current affinity list: 1
pid 591's current affinity list: 1
pid 592's current affinity list: 1
pid 596's current affinity list: 1
pid 597's current affinity list: 1
pid 599's current affinity list: 1
======= QEMU 32076 threads: =======
pid 32076's current affinity list: 0,2,3
pid 32094's current affinity list: 0,2,3
pid 32098's current affinity list: 0,2,3
pid 32099's current affinity list: 0,2,3
pid 344's current affinity list: 0,2,3

79e8a31a-712c-4d1a-be9d-1f41a6da1300:~# for pid in $(pgrep qemu) ; do echo "======= QEMU $pid threads: =======" ; for spid in $(ps -T -o spid= -p "$pid" )
; do taskset -pc "$spid" ; done ;

done
======= QEMU 578 threads: =======
pid 578's current affinity list: 1
pid 591's current affinity list: 1
pid 592's current affinity list: 1
pid 596's current affinity list: 1
pid 597's current affinity list: 1
pid 979's current affinity list: 0-3
pid 1954's current affinity list: 1
======= QEMU 1669 threads: =======
pid 1669's current affinity list: 2
pid 1682's current affinity list: 2
pid 1683's current affinity list: 2
pid 1688's current affinity list: 2
pid 1689's current affinity list: 2
pid 1702's current affinity list: 2
pid 1813's current affinity list: 0-3
pid 1814's current affinity list: 2
pid 1815's current affinity list: 2
pid 1816's current affinity list: 2
pid 1817's current affinity list: 2
======= QEMU 32076 threads: =======
pid 32076's current affinity list: 0,3
pid 32094's current affinity list: 0,3
pid 32098's current affinity list: 0,3
pid 32099's current affinity list: 0,3
pid 1163's current affinity list: 0,3

======= QEMU 578 threads: =======
pid 578's current affinity list: 1
pid 591's current affinity list: 1
pid 592's current affinity list: 1
pid 596's current affinity list: 1
pid 597's current affinity list: 1
pid 979's current affinity list: 0-3
pid 3507's current affinity list: 1
======= QEMU 1669 threads: =======
pid 1669's current affinity list: 2
pid 1682's current affinity list: 2
pid 1683's current affinity list: 2
pid 1688's current affinity list: 2
pid 1689's current affinity list: 2
pid 2258's current affinity list: 0-3
pid 3506's current affinity list: 2
======= QEMU 3163 threads: =======
pid 3163's current affinity list: 3
pid 3178's current affinity list: 3
pid 3185's current affinity list: 3
pid 3193's current affinity list: 3
pid 3194's current affinity list: 3
pid 3201's current affinity list: 3
pid 3251's current affinity list: 0-3
pid 3503's current affinity list: 0-3
pid 3504's current affinity list: 0-3
pid 3505's current affinity list: 0-3
======= QEMU 32076 threads: =======
pid 32076's current affinity list: 0
pid 32094's current affinity list: 0
pid 32098's current affinity list: 0
pid 32099's current affinity list: 0
pid 2881's current affinity list: 0

Removing Pinned VMs one-by-one

======= QEMU 1669 threads: =======
pid 1669's current affinity list: 2
pid 1682's current affinity list: 2
pid 1683's current affinity list: 2
pid 1688's current affinity list: 2
pid 1689's current affinity list: 2
pid 2258's current affinity list: 0-3
pid 4727's current affinity list: 2
pid 4728's current affinity list: 2
pid 4729's current affinity list: 2
pid 4762's current affinity list: 0-3
======= QEMU 3163 threads: =======
pid 3163's current affinity list: 3
pid 3178's current affinity list: 3
pid 3185's current affinity list: 3
pid 3193's current affinity list: 3
pid 3194's current affinity list: 3
pid 3593's current affinity list: 0-3
======= QEMU 32076 threads: =======
pid 32076's current affinity list: 0,1
pid 32094's current affinity list: 0,1
pid 32098's current affinity list: 0,1
pid 32099's current affinity list: 0,1
pid 2881's current affinity list: 0,1

======= QEMU 1669 threads: =======
pid 1669's current affinity list: 2
pid 1682's current affinity list: 2
pid 1683's current affinity list: 2
pid 1688's current affinity list: 2
pid 1689's current affinity list: 2
pid 2258's current affinity list: 0-3
======= QEMU 32076 threads: =======
pid 32076's current affinity list: 0,1
pid 32094's current affinity list: 0,1
pid 32098's current affinity list: 0,1
pid 32099's current affinity list: 0,1
pid 2881's current affinity list: 0,1

79e8a31a-712c-4d1a-be9d-1f41a6da1300:~# for pid in $(pgrep qemu) ; do echo "======= QEMU $pid threads: =======" ; for spid in $(ps -T -o spid= -p "$pid" )
; do taskset -pc "$spid" ; done ;

done
======= QEMU 32076 threads: =======
pid 32076's current affinity list: 0-3
pid 32094's current affinity list: 0-3
pid 32098's current affinity list: 0-3
pid 32099's current affinity list: 0-3
pid 5918's current affinity list: 0-3
pid 6455's current affinity list: 0-3

rene · 2024-10-25T08:51:34Z

@roja-zededa , in the commit title "pillar: Adopt pillar to use native cpupinning", I guess you meant: "pillar: Adapt pillar to use..."

rene · 2024-10-25T09:04:24Z

pkg/pillar/types/domainmgrtypes.go

@@ -242,7 +242,7 @@ type VmConfig struct {
 	ExtraArgs  string // added to bootargs
 	BootLoader string // default ""
 	// For CPU pinning
-	CPUs string // default "", list of "1,2"
+	CPUs []int // default nil, list of [1,2]


@roja-zededa , this change implies on change the API as well: https://github.com/lf-edge/eve-api/blob/main/proto/config/vm.proto#L48

I'm not sure how this impacts the controller.... I wouldn't change the type, you can still keep as string and parse it accordingly....

+1 changes on API would require changes on controller

Nikolay authored this commit. @OhmSpectator Could you please take a look at it?

cmd/zedagent/parseconfig.go parses the received protobuf and produces the golang structs such as this. Thus it can be made to parse the existing protbuf string format and produce an array of integers.
Thus no need to change the EVE API.

This field in the protobuf that @rene pointed to is not filled out by the controller at the moment. So we don't even have to change the parsing logic. It's currently used only internally in the DomainStatus.

uncleDecart

I would also add test to domainmgr checking that CPUs were set as expected in VmConfig.CPUs (something like this) and that generated hypervisor configs are as expected

OhmSpectator · 2024-10-30T10:10:04Z

======= QEMU 1669 threads: =======
pid 1669's current affinity list: 2
pid 1682's current affinity list: 2
pid 1683's current affinity list: 2
pid 1688's current affinity list: 2
pid 1689's current affinity list: 2
pid 2258's current affinity list: 0-3
======= QEMU 32076 threads: =======
pid 32076's current affinity list: 0,1
pid 32094's current affinity list: 0,1
pid 32098's current affinity list: 0,1
pid 32099's current affinity list: 0,1
pid 2881's current affinity list: 0,1

This looks strange as I would expect

> ======= QEMU 1669 threads: =======
> pid 1669's current affinity list: 2
> pid 1682's current affinity list: 2
> pid 1683's current affinity list: 2
> pid 1688's current affinity list: 2
> pid 1689's current affinity list: 2
> pid 2258's current affinity list: 0-3
> ======= QEMU 32076 threads: =======
> pid 32076's current affinity list: 0,1,3
> pid 32094's current affinity list: 0,1,3
> pid 32098's current affinity list: 0,1,3
> pid 32099's current affinity list: 0,1,3
> pid 2881's current affinity list: 0,1,3

But maybe the CPUs were redistributed a little bit later.

OhmSpectator

@roja-zededa , thanks for the tests. The results look fine. Nevertheless, I would prefer to run the tests as they are described in the doc, as they also involve some corner cases.

Also, could you please run this snippet to check the affinities (should be run from the debug container with the procps package installed):

for pid in $(pgrep qemu); do 
    echo "======= QEMU $pid threads: ======="; 
    for spid in $(ps -T -o spid= -p "$pid"); do 
        echo -n "Thread $spid affinity: "; taskset -pc "$spid"; 
        cgpath=$(grep -m1 cpuset /proc/$spid/cgroup | cut -d: -f3)
        echo "Cgroup cpuset: $(cat /sys/fs/cgroup/cpuset${cgpath}/cpuset.cpus)"
    done; 
done

I want to see how it will look like for the non-VCPU threads, as they are now not affected by the CPU pinning:

======= QEMU 1669 threads: =======
pid 1669's current affinity list: 2
pid 1682's current affinity list: 2
pid 1683's current affinity list: 2
pid 1688's current affinity list: 2
pid 1689's current affinity list: 2
pid 2258's current affinity list: 0-3 <---- here
pid 4727's current affinity list: 2
pid 4728's current affinity list: 2
pid 4729's current affinity list: 2
pid 4762's current affinity list: 0-3 <---- here

I also want to understand, why most of the threads have affinity corresponding to the CPU mask and why not others... I expected VCPU thread to affected only, but we definetly see more. If you could, would be nice if you check how the new version of QEMU handles this option:

-object thread-context,id=tc1,...

may be we should do the same for tc0, or only for tc0?

roja-zededa · 2024-10-30T20:50:14Z

======= QEMU 1669 threads: =======
pid 1669's current affinity list: 2
pid 1682's current affinity list: 2
pid 1683's current affinity list: 2
pid 1688's current affinity list: 2
pid 1689's current affinity list: 2
pid 2258's current affinity list: 0-3
======= QEMU 32076 threads: =======
pid 32076's current affinity list: 0,1
pid 32094's current affinity list: 0,1
pid 32098's current affinity list: 0,1
pid 32099's current affinity list: 0,1
pid 2881's current affinity list: 0,1

This looks strange as I would expect
> ======= QEMU 1669 threads: =======
> pid 1669's current affinity list: 2
> pid 1682's current affinity list: 2
> pid 1683's current affinity list: 2
> pid 1688's current affinity list: 2
> pid 1689's current affinity list: 2
> pid 2258's current affinity list: 0-3
> ======= QEMU 32076 threads: =======
> pid 32076's current affinity list: 0,1,3
> pid 32094's current affinity list: 0,1,3
> pid 32098's current affinity list: 0,1,3
> pid 32099's current affinity list: 0,1,3
> pid 2881's current affinity list: 0,1,3
But maybe the CPUs were redistributed a little bit later.

The deleted cpus are being reclaimed. Here is the trace.
QEMU 22745 - No CPU pin
QEMU 23728 - 1 CPU pinned
QEMU 24930 - 1CPU Pinned

======= QEMU 22745 threads: =======
pid 22745's current affinity list: 0,3
pid 22774's current affinity list: 0,3
pid 22778's current affinity list: 0,3
pid 22779's current affinity list: 0,3
pid 24456's current affinity list: 0,3
pid 25204's current affinity list: 0,3
pid 25216's current affinity list: 0-3
======= QEMU 23728 threads: =======
pid 23728's current affinity list: 1
pid 23742's current affinity list: 1
pid 23743's current affinity list: 1
pid 23747's current affinity list: 1
pid 23748's current affinity list: 1
pid 24056's current affinity list: 0-3
======= QEMU 24930 threads: =======
pid 24930's current affinity list: 2
pid 24944's current affinity list: 2
pid 24945's current affinity list: 2
pid 24949's current affinity list: 2
pid 24950's current affinity list: 2
pid 24952's current affinity list: 2
pid 25024's current affinity list: 0-3
pid 25025's current affinity list: 2
pid 25026's current affinity list: 2
pid 25027's current affinity list: 2

Removal:

Deletea VM

======= QEMU 22745 threads: =======
pid 22745's current affinity list: 0,1,3
pid 22774's current affinity list: 0,1,3
pid 22778's current affinity list: 0,1,3
pid 22779's current affinity list: 0,1,3
pid 27625's current affinity list: 0-3
======= QEMU 24930 threads: =======
pid 24930's current affinity list: 2
pid 24944's current affinity list: 2
pid 24945's current affinity list: 2
pid 24949's current affinity list: 2
pid 24950's current affinity list: 2
pid 25420's current affinity list: 0-3
pid 27674's current affinity list: 2

roja-zededa · 2024-10-31T18:41:38Z

@OhmSpectator @rene Covered all the test cases in this document. The results look good to me. https://docs.google.com/document/d/1qoCq7SPk6UR2LCb6APVbmLLgo7W7wONJUncTrXCbPeM/edit?tab=t.0#heading=h.p1hte28jbxjx Please let me know if you have more questions.

OhmSpectator · 2024-11-01T09:50:47Z

@roja-zededa, please address the rest of my comments here:
#4212 (review)

I want to understand what are the the threads that run only on a given subset of CPUs and what are the threads that run on all CPUs. To understand it, please check how the thread contexts work. We use tc1, but we should understand which exactly threads are affected by it.
Check not only the CPU affinities but the CPUset in cgroup. I have already provided a snippet for that:

for pid in $(pgrep qemu); do 
    echo "======= QEMU $pid threads: ======="; 
    for spid in $(ps -T -o spid= -p "$pid"); do 
        echo -n "Thread $spid affinity: "; taskset -pc "$spid"; 
        cgpath=$(grep -m1 cpuset /proc/$spid/cgroup | cut -d: -f3)
        echo "Cgroup cpuset: $(cat /sys/fs/cgroup/cpuset${cgpath}/cpuset.cpus)"
    done; 
done

roja-zededa · 2024-11-04T20:42:00Z

@roja-zededa, please address the rest of my comments here: #4212 (review)

I want to understand what are the the threads that run only on a given subset of CPUs and what are the threads that run on all CPUs. To understand it, please check how the thread contexts work. We use tc1, but we should understand which exactly threads are affected by it.

Check not only the CPU affinities but the CPUset in cgroup. I have already provided a snippet for that:
for pid in $(pgrep qemu); do 
    echo "======= QEMU $pid threads: ======="; 
    for spid in $(ps -T -o spid= -p "$pid"); do 
        echo -n "Thread $spid affinity: "; taskset -pc "$spid"; 
        cgpath=$(grep -m1 cpuset /proc/$spid/cgroup | cut -d: -f3)
        echo "Cgroup cpuset: $(cat /sys/fs/cgroup/cpuset${cgpath}/cpuset.cpus)"
    done; 
done

@OhmSpectator Updated this doc:https://docs.google.com/document/d/1qoCq7SPk6UR2LCb6APVbmLLgo7W7wONJUncTrXCbPeM/edit?tab=t.0#heading=h.p1hte28jbxjx with the CPUset group info and CPU Affinity. Please refer to it. I don't see any issue with it so far.

roja-zededa · 2024-11-05T19:14:58Z

@roja-zededa, please address the rest of my comments here: #4212 (review)

I want to understand what are the the threads that run only on a given subset of CPUs and what are the threads that run on all CPUs. To understand it, please check how the thread contexts work. We use tc1, but we should understand which exactly threads are affected by it.

Check not only the CPU affinities but the CPUset in cgroup. I have already provided a snippet for that:
for pid in $(pgrep qemu); do 
    echo "======= QEMU $pid threads: ======="; 
    for spid in $(ps -T -o spid= -p "$pid"); do 
        echo -n "Thread $spid affinity: "; taskset -pc "$spid"; 
        cgpath=$(grep -m1 cpuset /proc/$spid/cgroup | cut -d: -f3)
        echo "Cgroup cpuset: $(cat /sys/fs/cgroup/cpuset${cgpath}/cpuset.cpus)"
    done; 
done
@OhmSpectator Updated this doc:https://docs.google.com/document/d/1qoCq7SPk6UR2LCb6APVbmLLgo7W7wONJUncTrXCbPeM/edit?tab=t.0#heading=h.p1hte28jbxjx with the CPUset group info and CPU Affinity. Please refer to it. I don't see any issue with it so far.

@OhmSpectator @rene @eriknordmark Please kickoff the tests.

eriknordmark

Re-run tests

OhmSpectator · 2024-11-05T21:52:08Z

@roja-zededa, thanks for the testsing! Interestingly, we enforce pinning more by setting CPUSet in a cgroup now rather than by setting affinity in QEMU. But let it be.

roja-zededa requested review from OhmSpectator, rene and rouming as code owners September 4, 2024 17:57

github-actions bot requested review from eriknordmark, rucoder and shjala September 4, 2024 17:58

roja-zededa changed the title ~~Testing and Integrating new qemu_thread_set_affinity definition from xentools-4.19.0 QEMU 8.0.4~~ Testing and Integrating new qemu_thread_set_affinity definition Sep 4, 2024

roja-zededa marked this pull request as draft September 4, 2024 18:04

roja-zededa closed this Sep 17, 2024

roja-zededa force-pushed the new-cpupinning branch from cd04e97 to 4732410 Compare September 17, 2024 17:27

roja-zededa reopened this Sep 17, 2024

roja-zededa force-pushed the new-cpupinning branch 2 times, most recently from 25221aa to 4c26806 Compare September 25, 2024 17:20

roja-zededa closed this Oct 1, 2024

roja-zededa force-pushed the new-cpupinning branch from 4c26806 to 7dd83ea Compare October 1, 2024 18:41

roja-zededa reopened this Oct 1, 2024

github-actions bot requested review from deitch, jsfakian, milan-zededa and uncleDecart October 1, 2024 19:29

roja-zededa force-pushed the new-cpupinning branch 2 times, most recently from 1d5f3ad to 91de957 Compare October 1, 2024 20:27

roja-zededa self-assigned this Oct 15, 2024

roja-zededa force-pushed the new-cpupinning branch from 60a59ac to 407735c Compare October 15, 2024 22:35

roja-zededa marked this pull request as draft October 16, 2024 17:29

roja-zededa force-pushed the new-cpupinning branch 4 times, most recently from 227a75a to 0a66a33 Compare October 22, 2024 19:37

roja-zededa force-pushed the new-cpupinning branch from 0a66a33 to 90db3a3 Compare October 23, 2024 20:12

roja-zededa marked this pull request as ready for review October 23, 2024 20:16

rene reviewed Oct 25, 2024

View reviewed changes

uncleDecart reviewed Oct 25, 2024

View reviewed changes

OhmSpectator reviewed Oct 30, 2024

View reviewed changes

eriknordmark approved these changes Nov 5, 2024

View reviewed changes

OhmSpectator approved these changes Nov 5, 2024

View reviewed changes

OhmSpectator merged commit d463c8e into lf-edge:master Nov 6, 2024
80 of 92 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Testing and Integrating new qemu_thread_set_affinity definition #4212

Testing and Integrating new qemu_thread_set_affinity definition #4212

roja-zededa commented Sep 4, 2024 •

edited

Loading

OhmSpectator commented Sep 4, 2024 •

edited

Loading

roja-zededa commented Sep 16, 2024

rouming commented Sep 16, 2024

OhmSpectator commented Sep 16, 2024

rouming commented Sep 17, 2024

roja-zededa commented Sep 17, 2024 •

edited

Loading

rouming commented Sep 18, 2024

OhmSpectator commented Oct 1, 2024

OhmSpectator commented Oct 16, 2024

roja-zededa commented Oct 16, 2024

OhmSpectator commented Oct 16, 2024

roja-zededa commented Oct 16, 2024

OhmSpectator commented Oct 16, 2024

roja-zededa commented Oct 23, 2024

rene commented Oct 25, 2024

rene Oct 25, 2024

uncleDecart Oct 25, 2024

roja-zededa Oct 29, 2024

eriknordmark Oct 29, 2024

OhmSpectator Oct 30, 2024

uncleDecart left a comment

OhmSpectator commented Oct 30, 2024

OhmSpectator left a comment

roja-zededa commented Oct 30, 2024

roja-zededa commented Oct 31, 2024 •

edited

Loading

OhmSpectator commented Nov 1, 2024

roja-zededa commented Nov 4, 2024

roja-zededa commented Nov 5, 2024

eriknordmark left a comment

OhmSpectator commented Nov 5, 2024

Testing and Integrating new qemu_thread_set_affinity definition #4212

Testing and Integrating new qemu_thread_set_affinity definition #4212

Conversation

roja-zededa commented Sep 4, 2024 • edited Loading

OhmSpectator commented Sep 4, 2024 • edited Loading

roja-zededa commented Sep 16, 2024

rouming commented Sep 16, 2024

OhmSpectator commented Sep 16, 2024

rouming commented Sep 17, 2024

roja-zededa commented Sep 17, 2024 • edited Loading

rouming commented Sep 18, 2024

OhmSpectator commented Oct 1, 2024

OhmSpectator commented Oct 16, 2024

roja-zededa commented Oct 16, 2024

OhmSpectator commented Oct 16, 2024

roja-zededa commented Oct 16, 2024

OhmSpectator commented Oct 16, 2024

roja-zededa commented Oct 23, 2024

rene commented Oct 25, 2024

rene Oct 25, 2024

Choose a reason for hiding this comment

uncleDecart Oct 25, 2024

Choose a reason for hiding this comment

roja-zededa Oct 29, 2024

Choose a reason for hiding this comment

eriknordmark Oct 29, 2024

Choose a reason for hiding this comment

OhmSpectator Oct 30, 2024

Choose a reason for hiding this comment

uncleDecart left a comment

Choose a reason for hiding this comment

OhmSpectator commented Oct 30, 2024

OhmSpectator left a comment

Choose a reason for hiding this comment

roja-zededa commented Oct 30, 2024

roja-zededa commented Oct 31, 2024 • edited Loading

OhmSpectator commented Nov 1, 2024

roja-zededa commented Nov 4, 2024

roja-zededa commented Nov 5, 2024

eriknordmark left a comment

Choose a reason for hiding this comment

OhmSpectator commented Nov 5, 2024

roja-zededa commented Sep 4, 2024 •

edited

Loading

OhmSpectator commented Sep 4, 2024 •

edited

Loading

roja-zededa commented Sep 17, 2024 •

edited

Loading

roja-zededa commented Oct 31, 2024 •

edited

Loading