Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pillar: Adopt pillar to use native QEMU CPU pinning options. #1

Conversation

OhmSpectator
Copy link

Update pillar's handling of QEMU guests to take advantage of native CPU pinning options introduced in the newer version of QEMU (7.2). This eliminates the need for our custom patches to QEMU for CPU pinning.

Changes include:

  • Refactoring CPU pinning to use integer slices instead of comma-separated strings.
  • Updating QEMU command-line arguments to include native CPU pinning options.
  • Ensuring compatibility with both KVM and Xen hypervisors.

This change allows us to leverage upstream QEMU improvements and simplifies the codebase by removing custom patches and complex string manipulations.

Tested with QEMU version 8.0.4.

@rucoder rucoder force-pushed the rucoder/xen-4.18.0-rc4 branch from 480fd81 to 79482da Compare October 31, 2023 15:06
@rucoder rucoder self-requested a review as a code owner October 31, 2023 15:06
@OhmSpectator OhmSpectator force-pushed the feature/use-native-qemu-cpu-affinity branch from b70b689 to 2ecb27f Compare October 31, 2023 15:30
@rucoder rucoder force-pushed the rucoder/xen-4.18.0-rc4 branch from 79482da to 729c4e2 Compare October 31, 2023 15:56
@OhmSpectator OhmSpectator force-pushed the feature/use-native-qemu-cpu-affinity branch from 2ecb27f to e348e35 Compare October 31, 2023 15:58
Update pillar's handling of QEMU guests to take advantage of native CPU pinning
options introduced in the newer version of QEMU (7.2). This eliminates the need
for our custom patches to QEMU for CPU pinning.

Changes include:
- Refactoring CPU pinning to use integer slices instead of comma-separated strings.
- Updating QEMU command-line arguments to include native CPU pinning options.
- Ensuring compatibility with both KVM and Xen hypervisors.

This change allows us to leverage upstream QEMU improvements and simplifies
the codebase by removing custom patches and complex string manipulations.

Tested with QEMU version 8.0.4.

Signed-off-by: Nikolay Martyanov <nikolay@zededa.com>
@roja-zededa
Copy link

@OhmSpectator This PR hasn't been merged because it doesn't do 1-1 CPU-pinning?

@OhmSpectator
Copy link
Author

@roja-zededa, this PR was just a part of a previous attempt to upgrade QEMU. I created it to be used later in @rucoder's original PR. I never targeted EVE master with it.
Technically, yes, it supported native QEMU CPU pinning, which does not do 1-to-1 CPU pinning. But according to @rouming it should not be a big problem. So, feel free to cherry-pick if you need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants