Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of Epoch into separate repository #1482

Merged
merged 18 commits into from
Mar 2, 2023
Merged

Migration of Epoch into separate repository #1482

merged 18 commits into from
Mar 2, 2023

Conversation

a-sr
Copy link
Collaborator

@a-sr a-sr commented Nov 19, 2022

This PR factors out all Eclipse (Epoch) specific projects and restructures the remaining source files such that they can be used as a sub module. The new repository is here: https://github.com/lf-lang/epoch
Implements parts of #1276.

Involved tasks (LF repo):

  • Move contents of org.lflang.diagram and org.lflang.ide to org.lflang
  • Remove all Epoch related projects
  • Move EclipseErrorRepoter to Epoch repo
  • Adjust mwe build configuration
  • Document mwe build configuration implications (@a-sr)
  • Adjust Gradle build
  • Adjust GH build actions
  • Fix Gradle tests

Involved tasks (Epoch repo):

  • Include lingua-franca repository as submodule
  • Adjust Maven build
  • Adjust mwe build configuration
  • Setup GH build actions
  • Adjust Oomph setup
  • (not possible) Reduce redundancy in mwe configurations
  • Fix eclipse test (template check)
  • Implement Epoch in-tool compilation test
  • Set repo to public

Remaining tasks:

@a-sr
Copy link
Collaborator Author

a-sr commented Nov 29, 2022

@cmnrd, @lhstrh I'd say the bulk of the work for the restructuring is done now. The Gradle build in LF works and likewise does the maven build in the new Epoch repo. Everything is as before, just in separate repos.
I still have a few open ToDos (see PR description) and I would appreciate if you could help me with these.
My current focus is on wrapping things up in the new Epoch repo. Hence, it would be great if one of you could take a look at the failing Gradle tests for this branch. After I moved the diagrams and ide plugins into org.lflang, suddenly the majority of JUnit test run by Gradle reported a SecurityException. I did not yet further investigated the stacktrace.

Btw, the build job in GH only fails for this PR because is uses the configuration from the master branch. Since I only removed the maven build commands, the GH configuration should be fine.

@a-sr a-sr added enhancement Enhancement of existing feature ide epoch Epoch IDE gradle Issues regarding Gradle build configuration epic labels Nov 29, 2022
@lhstrh
Copy link
Member

lhstrh commented Nov 29, 2022

This looks like fantastic progress, @a-sr! Thank you so much for doing this. It looks soooo much cleaner. I can pitch in with the remaining work. Perhaps @petervdonovan could with the adjustments that will be necessary in the VS Code repo.

@a-sr a-sr requested review from lhstrh and cmnrd December 8, 2022 18:53
@a-sr a-sr marked this pull request as ready for review December 8, 2022 18:53
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great! Thanks again for doing this. Let's hold off the merge for now, but I'll make it a priority to get it merged very soon.

org.lflang/build.gradle Outdated Show resolved Hide resolved
Co-authored-by: Marten Lohstroh <marten@berkeley.edu>
@lhstrh lhstrh merged commit 36e9eed into master Mar 2, 2023
@petervdonovan
Copy link
Collaborator

petervdonovan commented Mar 3, 2023

This branch deletes the generateLanguageDiagramServer Gradle task. How am I supposed to build the language server now?

Edit: Sorry for the noise, I understand what happened now. I will submit a PR in vscode-lingua-franca to bring it up to date.

@lhstrh
Copy link
Member

lhstrh commented Mar 4, 2023

Is it lf-lang/vscode-lingua-franca#100?

@petervdonovan petervdonovan added cleanup and removed enhancement Enhancement of existing feature labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup epic epoch Epoch IDE gradle Issues regarding Gradle build configuration ide
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants