Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epoch built for M1 Mac #1530

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Epoch built for M1 Mac #1530

merged 1 commit into from
Jan 10, 2023

Conversation

hokeun
Copy link
Member

@hokeun hokeun commented Jan 7, 2023

I propose adding ARM 64 Mac OS X as an Epoch build environment to support M1 Mac.

@hokeun hokeun requested review from a-sr, lhstrh and edwardalee January 7, 2023 18:35
@lhstrh
Copy link
Member

lhstrh commented Jan 7, 2023

Good idea! @a-sr has a major refactoring of the build system that is basically ready to go. Let's have him decide which should go first?

Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@a-sr
Copy link
Collaborator

a-sr commented Jan 9, 2023

Since the refactoring is already done, PR #1482 will removed the changed file anyway. Hence, I would suggest to drop this PR to prevent a conflict with #1482, unless someone needs an Epoch IDE for an M1 Apple before we merge #1482.
In any case, I created an PR in the new epoch repo (lf-lang/epoch#1) that will add M1 support for future Epoch versions.

@hokeun
Copy link
Member Author

hokeun commented Jan 10, 2023

Thanks, everyone! I'm not sure about the timeline for merging #1482, but I would like to suggest merging this for now as some people (including myself and some of my students/TAs who are preparing for the embedded systems class at Hanyang) are using M1 Mac. I checked #1482, and it seems to simply remove this pom.xml file. Thus, I think this change shouldn't block #1482. Please let me know if this causes any conflicts, I will be happy to help and revert this.

@hokeun hokeun merged commit ba0543f into master Jan 10, 2023
@lhstrh lhstrh changed the title Enable Epoch build for M1 Mac Epoch build for M1 Mac Jan 26, 2023
@lhstrh lhstrh added the feature New feature label Jan 26, 2023
@lhstrh lhstrh changed the title Epoch build for M1 Mac Epoch built for M1 Mac Jan 26, 2023
@hokeun hokeun deleted the epoch-m1 branch November 8, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants