Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SEGV in rugged_branch_collection.c #456

Closed
wants to merge 1 commit into from
Closed

fix SEGV in rugged_branch_collection.c #456

wants to merge 1 commit into from

Conversation

daroay
Copy link
Contributor

@daroay daroay commented Feb 3, 2015

Check if git_branch_iterator_new returned error when initializing iter

Error might be returned if for some reason the iter could not be initialized,
but currently that error is not being checked.

…_branch_collection.c

Check if git_branch_iterator_new returned error when initializing iter
@daroay daroay changed the title Update rugged_branch_collection.c fix SEGV in rugged_branch_collection.c Feb 3, 2015
@daroay
Copy link
Contributor Author

daroay commented Feb 3, 2015

Strange it fails, it just checks if error occurred.

@vmg
Copy link
Member

vmg commented Feb 4, 2015

@aiionx: looks like you moved the file around in your working directory. The source needs to be under ext/rugged for it to compile. Can you please move it back? :)

@daroay
Copy link
Contributor Author

daroay commented Feb 4, 2015

Oh i didnt noticed. How strange. Ill close this and create a new pull request.

Thanks

@daroay daroay closed this Feb 4, 2015
@daroay
Copy link
Contributor Author

daroay commented Feb 4, 2015

#457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants