Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SIGSEGV: check if there was an exception when initializing iterator #457

Merged
merged 1 commit into from
Feb 4, 2015

Conversation

daroay
Copy link
Contributor

@daroay daroay commented Feb 4, 2015

Currently there is no check if an exception was raised when initializing the iterator at each_branch function.

@daroay daroay changed the title exception check when initializing iterator Fix SIGSEGV: check if there was an exception when initializing iterator Feb 4, 2015
@daroay
Copy link
Contributor Author

daroay commented Feb 4, 2015

Not checking can produce a segmentation fault when trying to iterate over an uninitialized iterator.

@vmg
Copy link
Member

vmg commented Feb 4, 2015

This looks right this time. :))

Thanks for the PR!

vmg pushed a commit that referenced this pull request Feb 4, 2015
Fix SIGSEGV: check if there was an exception when initializing iterator
@vmg vmg merged commit 6010046 into libgit2:master Feb 4, 2015
@sandish2222
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants