perf: use msgio pooled buffers for received msgs #500
Conversation
|
@vyzo, any interest in this? |
|
ah sorry, didnt notice it. |
|
@Wondertan ping |
|
Also, lets do send buffers while at it; it can be a separate pr. |
nw, someone has to make FVM sound 😉 |
@vyzo, done
👌🏻 |
Wondertan
force-pushed
the
master
branch
2 times, most recently
from
ca3e349
to
137a1ab
Compare
|
Also, updated |
|
@Wondertan ping -- lets move this forward? |
|
@vyzo, I am currently on the two-week team onsite, and it's almost the end. Going to bring this over the finish line right after. The are some unanswered questions in the thread, IIRC |
|
yeah, whenever you can. I think reverting the eof change for now, or releasing the buffer, will do for merge. But lets create a follow up issue to discuss the general handling and come up with a good solution that can later be speced for other impls to follow. |
|
@vyzo, so I reverted the EOF change and started making an issue for it. Now it's only the reading side with pooled buffers. I can also try to squeeze in the write today if we want to. |
* perf: use msgio pooled buffers for received msgs (libp2p#500) * perf: use pooled buffers for message writes (libp2p#507) * improve handling of dead peers (libp2p#508) * chore: ignore signing keys during WithLocalPublication publishing (libp2p#497) * adds app specific rpc handler Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com> Co-authored-by: Viacheslav <viacheslavgonkivskyi@gmail.com>
The issue mentions only receiving buffers, so this PR only changes those. However, there might be value in changing sending buffers as well. Happy to update this in a subsequent commit if needed.
Closes #350