Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of dead peers #508

Merged
merged 1 commit into from
Nov 20, 2022

Conversation

Wondertan
Copy link
Contributor

Related to #506

Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, nice and simple.

Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, should it have length at least 1?
Its busy loop otherwise.

@Wondertan
Copy link
Contributor Author

Ohh, right, fixed

Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, looks great now; a redish diff!

@vyzo vyzo merged commit 7612414 into libp2p:master Nov 20, 2022
@vyzo
Copy link
Collaborator

vyzo commented Nov 20, 2022

I'd like to cut a patch release with these patches, can you do some sanity testing before I fo so?

@Wondertan Wondertan deleted the improve-dead-peer-handling branch November 20, 2022 11:45
@Wondertan
Copy link
Contributor Author

All the tests pass locally, or what do you mean?

@vyzo
Copy link
Collaborator

vyzo commented Nov 20, 2022

Run a canary node in production for a day or two?

@Wondertan
Copy link
Contributor Author

Wondertan commented Nov 21, 2022

@vyzo, Ok. I started my lotus daemon and miner on pubsub's master with the recent changes. I will report back on how it is going in a few days. It should give us enough confidence

yhassanzadeh13 added a commit to yhassanzadeh13/go-libp2p-pubsub that referenced this pull request Nov 24, 2022
* perf: use msgio pooled buffers for received msgs (libp2p#500)

* perf: use pooled buffers for message writes (libp2p#507)

* improve handling of dead peers (libp2p#508)

* chore: ignore signing keys during WithLocalPublication publishing (libp2p#497)

* adds app specific rpc handler

Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
Co-authored-by: Viacheslav <viacheslavgonkivskyi@gmail.com>
@Wondertan
Copy link
Contributor Author

@vyzo, 5 days of stable sync - :shipit:

@vyzo
Copy link
Collaborator

vyzo commented Nov 26, 2022

altight, i'll tag a release on momday. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants