switch to Google's Protobuf library, make protobufs compile with go generate #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
google-protobuf
branch
from
22ac18c
to
7ac6e3d
Compare
marten-seemann
force-pushed
the
google-protobuf
branch
14 times, most recently
from
31cb16b
to
8fdb066
Compare
marten-seemann
force-pushed
the
google-protobuf
branch
2 times, most recently
from
30b84fa
to
cb3c88b
Compare
marten-seemann
force-pushed
the
google-protobuf
branch
from
cb3c88b
to
3c268d8
Compare
marten-seemann
force-pushed
the
google-protobuf
branch
from
3c268d8
to
ed021eb
Compare
MarcoPolo
approved these changes
Jan 11, 2023
marten-seemann
force-pushed
the
google-protobuf
branch
from
ed021eb
to
f1109c5
Compare
This was referenced Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1976. Depends on #1978.
We'll first have to decide how we'll handle libp2p/go-msgio#38.