switch from deprecated gogo to google.golang.org/protobuf #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for libp2p/go-libp2p#1976.
While this is a straightforward change, this will break users, since the gogo
proto.Message
is different from the Google protobufproto.Message
. Sometimes, this will lead to compile time errors, sometimes to runtime panics. Once people update go-libp2p, they'll be forced onto the new version of this package that includes this PR (unless we go with (3), see below).Unfortunately, this package is used by a number of repos: https://cs.github.com/?scopeName=All+repos&scope=&q=github.com%2Flibp2p%2Fgo-msgio%2Fprotoio+language%3AGo+NOT+repo%3Alibp2p%2Fgo-libp2p#. (Lots of them are forks that we don't have to care about, but there are some actual users among there as well).
We now have the following options:
protoio
package toprotoiogoogle
(naming suggestions welcome).protoio
would continue to support GoGo, whereasprotoiogoogle
would use the Google package. We could then deprecateprotoio
and remove it in a couple of months. Downside:protoio
is a nice name,protoiogoogle
isn't.