Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUIC: drop draft-29 #2478

Closed
wants to merge 22 commits into from
Closed

QUIC: drop draft-29 #2478

wants to merge 22 commits into from

Conversation

MarcoPolo
Copy link
Collaborator

This does the minimal amount of changes to drop draft29. Along the way I ran into this issue: quic-go/quic-go#4029.

I'm torn between removing all the machinery of the multiversion quic transport or keeping it.

The reasons to keep it:

  1. It'll make adding support for QUIC-v2 very easy.
  2. It'll avoid us from reinventing this when we do. This is tricky code and this code works and has been deployed for a bit.

The reasons to remove it:

  1. Some complexity around muxing between versions that we aren't benefitting from right now.

I'm less worried about code paths that are untrodden, because we are still exercising these codepaths. They are just used to multiplex a single option.

If we think we'll add QUIC-v2 soon (next 6 months), I think we should keep it. Open to hear other folks thoughts on this.

@MarcoPolo
Copy link
Collaborator Author

I believe failures in Go 1.19 are expected.

Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably make sense to split this into two PRs:

  1. drop 29
  2. update quic-go

That way, we'll be able to bisect later if we encounter any problems.

@Neo2308
Copy link

Neo2308 commented Aug 15, 2023

@marten-seemann could we use #2485 for the quic go update? I have also added the updated it in the subdirs similar to this PR.

@MarcoPolo
Copy link
Collaborator Author

Closing in favor of #2487 and #2488

@MarcoPolo MarcoPolo closed this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants