Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: update quic-go to v0.37.5 #2488

Merged
merged 5 commits into from
Aug 17, 2023

Conversation

MarcoPolo
Copy link
Collaborator

This branch is targetting on #2487. Updates quic-go and our usage of it. I'd recommend reviewing this PR commit by commit because the hack to avoid running examples in Go 1.21 is noisy.

The workaround for examples is only temporary. The issue is that the examples use a released version of go-libp2p, but no released version supports Go 1.21 yet. This ignores Go 1.21 in the examples. This commit is designed to be reverted when we release the next version of go-libp2p.

Also note that this works around this issue: quic-go/quic-go#4029. A later version of quic-go will fix this.

@MarcoPolo MarcoPolo mentioned this pull request Aug 15, 2023
@MarcoPolo MarcoPolo changed the title quic-go: Update quic-go to v0.37.4 QUIC: Update quic-go to v0.37.4 Aug 15, 2023
Revert this commit when we release a new go-libp2p version compatible
with Go 1.21
@MarcoPolo
Copy link
Collaborator Author

Failing interop tests against zig-libp2p pretty reliably. Debugging this now.

@MarcoPolo
Copy link
Collaborator Author

Interop issue will be fixed in the next version of quic-go

@marten-seemann marten-seemann changed the title QUIC: Update quic-go to v0.37.4 quic: update quic-go to v0.37.5 Aug 17, 2023
@marten-seemann marten-seemann self-requested a review August 17, 2023 06:26
@marten-seemann marten-seemann mentioned this pull request Aug 16, 2023
21 tasks
@marten-seemann marten-seemann merged commit b032c7a into marco/drop-draft29-only Aug 17, 2023
18 checks passed
@marten-seemann
Copy link
Contributor

Wrong merge target. Will recreate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants