Fix address advertisement bugs #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we can't find the default route, advertise all addresses so we have something.
Stebalien
force-pushed
the
fix/fallback-addrs
branch
from
eeb90af
to
3d57d61
Compare
aschmahmann
reviewed
Jul 7, 2020
p2p/host/basic/basic_host.go
Outdated
Comment on lines
295
to
296
| // If we failed to lookup interface addrs. | ||
| if len(h.allInterfaceAddrs) == 0 { |
There was a problem hiding this comment.
Why does this generally occur? If it's a user configuration or router error is it worth logging it?
There was a problem hiding this comment.
This can happen due to OS restrictions, or if the there are no network devices. We could probably just detect this case at the top and bail entirely.
There was a problem hiding this comment.
I've changed this logic to only use fallback addresses if InterfaceMultiaddrs fails. If it just returns no addresses, we now accept that we have no addresses.
Co-authored-by: Adin Schmahmann <adin.schmahmann@gmail.com>
* If we fail to lookup interface addresses, do our best and bail. * Only fallback on guessing addresses if we fail to lookup any interface addresses. If the interface address lookup function returns nothing, accept that we have no IP addresses and move on. * Log when the NAT returns a bad address.
aschmahmann
approved these changes
Jul 7, 2020
Co-authored-by: Adin Schmahmann <adin.schmahmann@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes several address advertisements bugs that slipped through into go-ipfs 0.6.0.
We really need tests for this code, but that will likely require some mocking.