Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix address advertisement bugs #974

Merged
merged 9 commits into from
Jul 7, 2020
Merged

Fix address advertisement bugs #974

merged 9 commits into from
Jul 7, 2020

Commits on Jul 2, 2020

  1. fix: use all interface addresses when we can't find the default route 

    When we can't find the default route, advertise all addresses so we have something.
    @Stebalien
    Stebalien committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    743d1cf View commit details
    Browse the repository at this point in the history

  2. fix: don't add advertise unspecified addresses

    @Stebalien
    Stebalien committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    a0ce610 View commit details
    Browse the repository at this point in the history

  3. fix: resolve addresses before looking up observed addresses

    @Stebalien
    Stebalien committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    e03a031 View commit details
    Browse the repository at this point in the history

  4. fix: only advertise global unicast

    @Stebalien
    Stebalien committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    293929e View commit details
    Browse the repository at this point in the history

  5. fix: filter link-local addresses from advertisement

    @Stebalien
    Stebalien committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    2cc1fa6 View commit details
    Browse the repository at this point in the history

  6. test: fix basic host addr tests

    @Stebalien
    Stebalien committed Jul 2, 2020
    Configuration menu
    Copy the full SHA
    3d57d61 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2020

  1. Fix comment typo 

    Co-authored-by: Adin Schmahmann <adin.schmahmann@gmail.com>
    @Stebalien @aschmahmann
    Stebalien and aschmahmann authored Jul 7, 2020
    Configuration menu
    Copy the full SHA
    5d7d30d View commit details
    Browse the repository at this point in the history

  2. address code review and cleanup some edge cases 

    * If we fail to lookup interface addresses, do our best and bail.
* Only fallback on guessing addresses if we fail to lookup any interface
addresses. If the interface address lookup function returns nothing, accept that
we have no IP addresses and move on.
* Log when the NAT returns a bad address.
    @Stebalien
    Stebalien committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    0f8eb7b View commit details
    Browse the repository at this point in the history

  3. Fix english. 

    Co-authored-by: Adin Schmahmann <adin.schmahmann@gmail.com>
    @Stebalien @aschmahmann
    Stebalien and aschmahmann authored Jul 7, 2020
    Configuration menu
    Copy the full SHA
    8cb0350 View commit details
    Browse the repository at this point in the history