remove "Chan" type #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will let us test with unified CI. |
msgio/msgio.go
Outdated
| @@ -1,108 +0,0 @@ | |||
| package main | |||
There was a problem hiding this comment.
Why is this file being deleted?
There was a problem hiding this comment.
Less code to maintain. But I'll restore it, there's really no motivation to remove it.
It's not used anywhere and it makes go-vet unhappy due to the ReadFrom/WriteTo signatures. These could be fixed, but maintianing this code isn't worth it.
Stebalien
force-pushed
the
feat/remove-chan
branch
from
00e4e50
to
e20bcc3
Compare
marten-seemann
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type isn't used anywhere and doesn't conform to go's ReadFrom/WriteTo interfaces. Unfortunately,
go vetdoesn't have any way to say "please ignore this error", so our options were to:Given that it isn't used and hasn't been for years, I opted for the latter. We can always re-implement it later if we need it (and bring it up to do date with idiomatic go).