Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove "Chan" type #23

Merged
merged 2 commits into from
Aug 5, 2021
Merged

remove "Chan" type #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f269528
feat: remove the Chan type
Stebalien Aug 2, 2021
e20bcc3
fix: staticcheck issues
Stebalien Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 0 additions & 109 deletions chan.go
View file
Open in desktop

This file was deleted.

113 changes: 0 additions & 113 deletions chan_test.go
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions limit_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,7 @@ func TestLimitWriter(t *testing.T) {
t.Fatal("Expected to write 3 bytes with no errors")
}
err = writer.Flush()
if err != nil {
t.Fatal(err)
}
}
9 changes: 7 additions & 2 deletions msgio_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ import (
"time"
)

func randBuf(r *rand.Rand, size int) []byte {
buf := make([]byte, size)
_, _ = r.Read(buf)
return buf
}

func TestReadWrite(t *testing.T) {
buf := bytes.NewBuffer(nil)
writer := NewWriter(buf)
Expand Down Expand Up @@ -54,8 +60,7 @@ type testIoReadWriter struct {

func TestReadWriterClose(t *testing.T) {
r, w := io.Pipe()
var rw ReadWriteCloser
rw = NewReadWriter(testIoReadWriter{r, w})
rw := NewReadWriter(testIoReadWriter{r, w})
SubtestReaderWriterClose(t, rw)
}

Expand Down