Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to new multiformats #52

Merged
merged 6 commits into from
Jul 7, 2021

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Jun 2, 2021

Depends on:

BREAKING CHANGE: uses the CID class from the new multiformats module

Depends on:

- [ ] multiformats/js-multiformats#91

BREAKING CHANGE: uses the CID class from the new multiformats module
@achingbrain achingbrain marked this pull request as ready for review July 6, 2021 13:19
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the Readme to have ipfsHttpClient use the factory?

@achingbrain
Copy link
Member Author

Done

@vasco-santos vasco-santos merged commit f34c7d2 into master Jul 7, 2021
@vasco-santos vasco-santos deleted the chore/update-to-new-multiformats branch July 7, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants