chore: update to new multiformats #200
Conversation
Replaces cids and multibase with the new multiformats module. BREAKING CHANGE: uses the CID class from the new multiformats module
| @@ -10,7 +10,7 @@ | |||
| "test": "npm run test:node && npm run test:browser", | |||
| "test:node": "aegir test --ts -t node", | |||
| "test:browser": "aegir test -t browser", | |||
| "build": "aegir build", | |||
| "prepare": "aegir build", | |||
There was a problem hiding this comment.
Without this you can't depend on a branch of this repo as otherwise it has no types after install. prepare is run during release so it shouldn't break anything?
There was a problem hiding this comment.
We can keep it, but I would not remove the build script. Perhaps just add a new one?
There was a problem hiding this comment.
Can do, but then it'll build twice during release since npm runs prepare and aegir runs build
src/convert.js
Outdated
| @@ -163,8 +163,22 @@ function bytes2str (buf) { | |||
| * @param {string | Uint8Array | CID} hash | |||
| */ | |||
| function mh2bytes (hash) { | |||
| let cid | |||
|
|
|||
| if (typeof hash === 'string') { | |||
There was a problem hiding this comment.
We have this same logic in PeerId as well. Thinking if cid could offer a way of doing it?
There was a problem hiding this comment.
Could probably add it to CID.asCID, though I think that's supposed to convert between old and new CID instances, not try to parse whatever we throw at it. This is quite a common use case though.
There was a problem hiding this comment.
This is quite a common use case though
Can we export an util static function for this in multiformats then?
There was a problem hiding this comment.
I've created multiformats/js-multiformats#92
Replaces cids and multibase with the new multiformats module.
BREAKING CHANGE: uses the CID class from the new multiformats module