feat: Browser to Browser #90

ckousik · 2023-02-08T09:34:35Z

Adds the browser to browser transport. Supersedes #88

Add SDP protobufs.
Connection receiver initiates the RTCPeerConnection (when connecting from A to B, B will create the SDP offer after A establishes the relayed connection).
Add tests for protocol handler.
Add examples to CI.

ckousik · 2023-02-08T13:04:00Z

@ddimaria Still waiting on resolution for protocol name and code libp2p/specs#497 (comment)

mxinden · 2023-02-09T20:54:37Z

@ddimaria Still waiting on resolution for protocol name and code libp2p/specs#497 (comment)

@ckousik do I understand correctly that these discussions are not blocking this pull request? Or is all other work done?

ddimaria · 2023-02-09T22:26:45Z

@ddimaria Still waiting on resolution for protocol name and code libp2p/specs#497 (comment)

@ckousik do I understand correctly that these discussions are not blocking this pull request? Or is all other work done?

@mxinden Chinmay is out for the rest of the week. I can confirm that the spec-related decisions are not blocking this PR. I plan on adding a browser-to-browser example to the /examples directory and adding that to CI, as well as internally reviewing the code today/tomorrow. The goal is to have it ready for review sometime tomorrow.

ckousik · 2023-02-14T17:21:41Z

src/peer_transport/transport.ts

+
+    rawStream.close()
+    void connection.close()
+    // TODO(ckousik): Remove this delay. This is required because


@achingbrain For further clarification, consider a case where A is connecting to B using webrtc-direct. A and B both complete SDP exchange and their PeerConnections transition to the connected state. For the ICE connection, A is the controlled peer and B is the controlling peer. With reference to the description here, A moves to the connected state before B. This allows A to create a stream on the new connection before B has a chance to set up the datachannel callbacks.

MarcoPolo · 2023-02-21T19:11:47Z

todo We need to add CI testing for this example

MarcoPolo

Minor nits, but overall looks good to me. I'll leave the final approval to @achingbrain

Great work @ckousik :)

MarcoPolo · 2023-02-21T19:14:30Z

examples/browser-to-browser/index.js

+  appendOutput(`Dialing '${ma}'`)
+  const connection = await node.dial(ma)
+
+  if (!ma.protoCodes().includes(276)) {


276? Let's not forget to change this.

276 is the protoCode for circuit-relay. This is just used to differentiate between dialing a relay peer to start listening vs dialing a peer over relay to create an echo stream.

is there a library where we can ensure the protocode is more self documenting? (similar to codes in dag-json, dag-cbor, etc.. from ipld) we shouldn't be throwing magic numbers around

MarcoPolo · 2023-02-21T19:15:23Z

examples/go-libp2p-server/relay/main.go

+)
+
+func main() {
+	makeRelayV1()


Why not relayV2?

We haven't landed support for circuit v2 in js yet

For the record, tracking issue libp2p/js-libp2p#1029 and pull request libp2p/js-libp2p#1533.

These are in now, can we update this?

bump: please update to relay v2 (and the latest go-libp2p release)

src/muxer.ts

src/stream.ts

MarcoPolo · 2023-02-21T20:12:01Z

src/peer_transport/listener.ts

+  }
+
+    private listeningAddrs: Multiaddr[] = []
+    async listen (ma: Multiaddr): Promise<void> {


Do we need this? Aren't we listening already via some relay?

Probably not, but the rationale to add this is as follows:

Since webrtc-direct is a protocol, we can advertise support over any transport.

For running on node, we can use node-webrtc to replace all instances of RTCPeerConnection (webrtc-star and webrtc-direct currently do this).

Although, an argument can be made that any listener can support webrtc-direct since it is only implemented as a protocol.

src/peer_transport/transport.ts

examples/browser-to-browser/README.md

MarcoPolo

Some small nits. I'll fix up anything left and merge this soon. 🎉

examples/browser-to-server/tests/test.js

examples/browser-to-server/index.js

src/peer_transport/handler.ts

MarcoPolo · 2023-04-03T16:00:18Z

examples/browser-to-browser/index.js

+import { noise } from "@chainsafe/libp2p-noise"
+
+// singletons
+let outgoing_stream


Sorry, I should have been more clear. This shouldn't be a singleton because
there's no benefit of it being so. I'm not sure you could use this in a correct
way as a singleton anyways, since once you pass it into pipe you don't own
this stream. Since this is an example, the risk that people copy this verbatim
is pretty high. so we should remove this. I'll push a change.

src/peer_transport/transport.ts

MarcoPolo · 2023-04-04T00:18:10Z

examples/browser-to-browser/index.js

+    return
+  }
+
+  node.getMultiaddrs().forEach((ma) => {


Why do you need to remove an address?

MarcoPolo · 2023-04-07T20:58:10Z

Merging this since I've given it a review. I'm sure there's more things to fix, but I'd rather do those incrementally from now on. @achingbrain feel to review this at a later time

## [1.1.0](v1.0.5...v1.1.0) (2023-04-07) ### Features * Browser to Browser ([#90](#90)) ([add5c46](add5c46))

github-actions · 2023-04-07T21:03:32Z

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ckousik added 6 commits January 3, 2023 14:46

browser-to-browser over relayv1

07b5011

debug

cf7c2bd

fix race condition

f2fc6e3

Merge branch 'main' into feat/browser-to-browser

eefde36

fixes

3abb661

browser to browser

e50dd76

ckousik mentioned this pull request Feb 8, 2023

feat: browser-to-browser #88

Closed

8 tasks

ckousik added 2 commits February 8, 2023 15:59

fix tests

84c5b3c

add tests for handlers

5e3d29e

ckousik requested a review from ddimaria February 8, 2023 12:59

fix dep-check

43246b4

p-shahi mentioned this pull request Feb 8, 2023

WebRTC: Browser to Browser libp2p/js-libp2p#1462

Closed

2 tasks

ddimaria mentioned this pull request Feb 10, 2023

Will listen be supported for servers? #91

Closed

ddimaria and others added 4 commits February 13, 2023 08:37

Add browser to browser example with Node and Go relays

6472150

fix browser-to-browser example

83cd254

Attempt to fix example

f786bdb

race condition

5a08ed7

ckousik commented Feb 14, 2023

View reviewed changes

weboko mentioned this pull request Feb 15, 2023

WebRTC for Waku waku-org/js-waku#1181

Open

ckousik and others added 3 commits February 15, 2023 19:18

buffer incoming streams before upgrade

0ba969c

update stream protocol name

e1bf7de

Complete the browser-to-browser example

eafad87

MarcoPolo self-requested a review February 20, 2023 23:07

MarcoPolo reviewed Feb 21, 2023

View reviewed changes

ckousik added 2 commits February 22, 2023 04:43

address review

40d72fb

clarify circuit relay code usage

c24fb7e

MarcoPolo and others added 2 commits March 30, 2023 11:06

Use shorter multiaddr in example

f2df558

add answerpromise

a8efbfe

maschad reviewed Apr 1, 2023

View reviewed changes

examples/browser-to-browser/README.md Show resolved Hide resolved

Fix README for example

0a9f5d3

p-shahi mentioned this pull request Apr 3, 2023

Integrate private browser to private browser into the js-libp2p peer frontend libp2p/universal-connectivity#11

Closed

MarcoPolo added 5 commits April 3, 2023 11:46

Remove singleton

a86eb4b

Type the promise

497e7e2

Fix comment

57ad032

Refactor: Consolidate event handlers in resolveOnConnected

c30664b

Nits

257101e

MarcoPolo reviewed Apr 4, 2023

View reviewed changes

This was referenced Apr 4, 2023

feat: add private-to-private docs libp2p/docs#319

Merged

Address todos in browser-to-browser PR #112

Closed

MarcoPolo added 3 commits April 4, 2023 11:16

Update go multiaddr dep

489876b

Fix browser-to-server example

256fc95

Nit

7b9e98f

MarcoPolo approved these changes Apr 4, 2023

View reviewed changes

MarcoPolo mentioned this pull request Apr 4, 2023

Simplify /webrtc listen addr logic #113

Closed

MarcoPolo added 2 commits April 6, 2023 15:38

Workaround to not listen on p2p-circuit

57779d4

workaround: Fix multiaddr splitting

2184275

achingbrain mentioned this pull request Apr 7, 2023

example: create and host IPFS content from helia node (browser & nodejs) ipfs-examples/helia-examples#39

Open

Small rename cleanup

2f77031

MarcoPolo merged commit add5c46 into main Apr 7, 2023

MarcoPolo deleted the feat/browser-to-browser branch April 7, 2023 20:58

github-actions bot pushed a commit that referenced this pull request Apr 7, 2023

chore(release): 1.1.0 [skip ci]

5e8fca9

## [1.1.0](v1.0.5...v1.1.0) (2023-04-07) ### Features * Browser to Browser ([#90](#90)) ([add5c46](add5c46))

github-actions bot added the released label Apr 7, 2023

BigLep mentioned this pull request Apr 10, 2023

feat(webrtc): add WebRTC (prev. browser-to-browser) spec libp2p/specs#497

Merged

2 tasks

p-shahi mentioned this pull request May 5, 2023

Create a tutorial libp2p/universal-connectivity#67

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Browser to Browser #90

feat: Browser to Browser #90

ckousik commented Feb 8, 2023 •

edited by ddimaria

Loading

ckousik commented Feb 8, 2023

mxinden commented Feb 9, 2023

ddimaria commented Feb 9, 2023

ckousik Feb 14, 2023 •

edited

Loading

MarcoPolo commented Feb 21, 2023 •

edited by ddimaria

Loading

MarcoPolo left a comment

MarcoPolo Feb 21, 2023

ckousik Feb 21, 2023

SgtPooki Mar 16, 2023

MarcoPolo Feb 21, 2023

ckousik Feb 21, 2023

mxinden Feb 28, 2023

MarcoPolo Mar 9, 2023

p-shahi Mar 20, 2023

MarcoPolo Feb 21, 2023

ckousik Feb 21, 2023

MarcoPolo left a comment •

edited

Loading

MarcoPolo Apr 3, 2023

MarcoPolo Apr 4, 2023

MarcoPolo commented Apr 7, 2023

github-actions bot commented Apr 7, 2023

feat: Browser to Browser #90

feat: Browser to Browser #90

Conversation

ckousik commented Feb 8, 2023 • edited by ddimaria Loading

ckousik commented Feb 8, 2023

mxinden commented Feb 9, 2023

ddimaria commented Feb 9, 2023

ckousik Feb 14, 2023 • edited Loading

Choose a reason for hiding this comment

MarcoPolo commented Feb 21, 2023 • edited by ddimaria Loading

MarcoPolo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MarcoPolo left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MarcoPolo commented Apr 7, 2023

github-actions bot commented Apr 7, 2023

ckousik commented Feb 8, 2023 •

edited by ddimaria

Loading

ckousik Feb 14, 2023 •

edited

Loading

MarcoPolo commented Feb 21, 2023 •

edited by ddimaria

Loading

MarcoPolo left a comment •

edited

Loading