This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Browser to Browser #90
feat: Browser to Browser #90
Changes from 13 commits
07b5011
cf7c2bd
f2fc6e3
eefde36
3abb661
e50dd76
84c5b3c
5e3d29e
43246b4
6472150
83cd254
f786bdb
5a08ed7
0ba969c
e1bf7de
eafad87
40d72fb
c24fb7e
daed656
df5ce02
20e7c28
8ea980b
69c4208
d622b27
ddad046
602adc9
c8c2888
41c8e2d
a031dca
40fd90c
d4a6858
0b6a80f
6e8b3f6
32aa877
d167645
55c4f7b
e7a2623
45f47f2
05c783d
eb64c85
9d831a8
08575d4
f2df558
a8efbfe
0a9f5d3
a86eb4b
497e7e2
57ad032
c30664b
257101e
489876b
256fc95
7b9e98f
57779d4
2184275
2f77031
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be done by the library? Do we expect every user to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The webrtc library does not add any new multiaddresses to the peerStore. Given the discussion regarding multiaddresses, I feel it should add a new mulitaddress. However, the peerstore does not seem to have a way to atomically remove an address for a peer. https://github.com/libp2p/js-libp2p-interfaces/blob/master/packages/interface-peer-store/src/index.ts#L126
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need to remove an address?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#113