-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: close streams gracefully #1868
Closed
achingbrain
wants to merge
12
commits into
feat/merge-stat-properties
from
fix/close-streams-gracefully-ci
Closed
fix!: close streams gracefully #1868
achingbrain
wants to merge
12
commits into
feat/merge-stat-properties
from
fix/close-streams-gracefully-ci
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactors `.close`, `closeRead` and `.closeWrite` methods on the `Stream` interface to be async - The `Connection` interface now has `.close` and `.abort` methods - `.close` on `Stream`s and `Connection`s wait for the internal message queues to empty before closing - `.abort` on `Stream`s and `Connection`s close the underlying stream immediately and discards any unsent data - `@chainsafe/libp2p-yamux` now uses the `AbstractStream` class from `@libp2p/interface` the same as `@libp2p/mplex` and `@libp2p/webrtc` Follow-up PRs will be necessary to `@chainsafe/libp2p-yamux`, `@chainsafe/libp2p-gossipsub` and `@chainsafe/libp2p-noise` though they will not block the release as their code is temporarily added to this repo to let CI run. Fixes #1793 Fixes #656 BREAKING CHANGE: the `.close`, `closeRead` and `closeWrite` methods on the `Stream` interface are now asynchronous
chore: adjust logs
Pushed to a different branch because for some reason GitHub isn't noticing pushes to #1864 |
Closing as GitHub appears to have woken up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.close
,closeRead
and.closeWrite
methods on theStream
interface to be asyncConnection
interface now has.close
and.abort
methods.close
onStream
s andConnection
s wait for the internal message queues to empty before closing.abort
onStream
s andConnection
s close the underlying stream immediately and discards any unsent data@chainsafe/libp2p-yamux
now uses theAbstractStream
class from@libp2p/interface
the same as@libp2p/mplex
and@libp2p/webrtc
Follow-up PRs will be necessary to
@chainsafe/libp2p-yamux
,@chainsafe/libp2p-gossipsub
and@chainsafe/libp2p-noise
though they will not block the release as their code is temporarily added to this repo to let CI run.
Fixes #1793
Fixes #656
BREAKING CHANGE: the
.close
,closeRead
andcloseWrite
methods on theStream
interface are now asynchronous