-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: close streams gracefully #1868
Closed
achingbrain
wants to merge
12
commits into
feat/merge-stat-properties
from
fix/close-streams-gracefully-ci
Closed
fix!: close streams gracefully #1868
achingbrain
wants to merge
12
commits into
feat/merge-stat-properties
from
fix/close-streams-gracefully-ci
Commits on Jul 3, 2023
-
fix!: close streams gracefully
- Refactors `.close`, `closeRead` and `.closeWrite` methods on the `Stream` interface to be async - The `Connection` interface now has `.close` and `.abort` methods - `.close` on `Stream`s and `Connection`s wait for the internal message queues to empty before closing - `.abort` on `Stream`s and `Connection`s close the underlying stream immediately and discards any unsent data - `@chainsafe/libp2p-yamux` now uses the `AbstractStream` class from `@libp2p/interface` the same as `@libp2p/mplex` and `@libp2p/webrtc` Follow-up PRs will be necessary to `@chainsafe/libp2p-yamux`, `@chainsafe/libp2p-gossipsub` and `@chainsafe/libp2p-noise` though they will not block the release as their code is temporarily added to this repo to let CI run. Fixes #1793 Fixes #656 BREAKING CHANGE: the `.close`, `closeRead` and `closeWrite` methods on the `Stream` interface are now asynchronous
Configuration menu - View commit details
-
Copy full SHA for ff1c673 - Browse repository at this point
Copy the full SHA ff1c673View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08a3e06 - Browse repository at this point
Copy the full SHA 08a3e06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d1d604 - Browse repository at this point
Copy the full SHA 0d1d604View commit details
Commits on Jul 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2afdee1 - Browse repository at this point
Copy the full SHA 2afdee1View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4025a6 - Browse repository at this point
Copy the full SHA d4025a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ab0191 - Browse repository at this point
Copy the full SHA 6ab0191View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b35a0b - Browse repository at this point
Copy the full SHA 9b35a0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dc9026 - Browse repository at this point
Copy the full SHA 2dc9026View commit details -
Configuration menu - View commit details
-
Copy full SHA for 126791e - Browse repository at this point
Copy the full SHA 126791eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f267100 - Browse repository at this point
Copy the full SHA f267100View commit details
Commits on Jul 5, 2023
-
chore: set CI env var in dockerfiles to disable coloured output
chore: adjust logs
Configuration menu - View commit details
-
Copy full SHA for 4759f62 - Browse repository at this point
Copy the full SHA 4759f62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87bec2c - Browse repository at this point
Copy the full SHA 87bec2cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.