*: Fix clippy warnings #2615
Merged
*: Fix clippy warnings #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
reviewed
Apr 18, 2022
|
@mxinden Thanks for looking into it. What do you think about merging this and iterating over it to avoid one massive PR on a long-living branch? There are quite a lot of other issues reported by the pedantic clippy (most of which make sense). |
mxinden
approved these changes
Apr 19, 2022
Sounds good to me. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! After some time tidying up (tried to do something different but I always start with a linter :D ) I noticed you use a custom clippy command. Figured I'll propose some of the changes I made anyway.
Is there a specific reason why many of the lints are disabled? Or do you think it'd be useful to fix the offending pedantic and style issues and disable the suppressions? (complex type may be overkill though)