*: Activate clippy::style lint group

[LesnyRumcajs]

Description

Enabled clippy style warnings and fixed the corresponding issues. I had to suppress some of them to not break the existing API (we could consider resolving those for a major release).

Links to any relevant issues

#2615

Open Questions

Change checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• A changelog entry has been made in the appropriate crates

[thomaseizinger]

I am a fan of clippy myself, happy to move forward with this.
What do you think @mxinden?

[thomaseizinger]

This is quite the monster boolean condition now. Perhaps we should extract 3 boolean variables that we can then chain together to make this more readable?

[LesnyRumcajs]

For readability, it would make sense, but it would kill the possibility of short-circuiting, which may result in a performance drop.

[thomaseizinger]

I guess functions would allow for readability and short-circuiting?

[LesnyRumcajs]

Indeed, a lambda would do the trick! For the first two conditions I don't think it would help much, i.e. !self.duplicate_cache.contains(&id) would most likely become duplicate_cache.contains(&id). Is it fine for you?

The last one is definitely a monster though and I'd be happy to turn it into a short lambda. Any suggestions on a meaningful name for it?

[thomaseizinger]

Probably even better would be to do:

impl Gossipsub {
	fn want_message(&self, id: ???) -> bool {
		if self.duplicate_cache.contains(&id) {
			return false;
		}

		if self.pending_iwant_msgs.contains(&id) {
			return false;
		}

		self.peer_score
     		  .as_ref()
            .map(|(_, _, _, promises)| !promises.contains(&id))
            .unwrap_or(true)
	}
}

Although I think clippy might complain about this one being possible to write as a && chain.

[LesnyRumcajs]

Good idea! I went ahead with similar change. I was a bit confused with a contains method being mutable for no visible reason so I made them immutable. Maybe pedantic clippy would have caught that before.

[dignifiedquire]

big fan of clippy myself, very much in favor of this in general

[thomaseizinger]

Side-note @LesnyRumcajs : We use squash-merge so please don't force-push :)
Makes it easier to see the diff since the last review!

[LesnyRumcajs]

Side-note @LesnyRumcajs : We use squash-merge so please don't force-push :) Makes it easier to see the diff since the last review!

Sure thing. I was uncertain how it would behave coming from my fork which was a bit outdated so I defaulted to my typical routine. :)

[mxinden]

Just one nit pick. Otherwise looks good to me. Thanks for the help!