Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(swarm)!: remove PollParameters #4490

Merged
merged 14 commits into from
Oct 24, 2023
Merged

Conversation

thomaseizinger
Copy link
Contributor

Description

Resolves: #3124.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger added this to the v0.53.0 milestone Sep 12, 2023
@thomaseizinger
Copy link
Contributor Author

Rustdoc CI should pass once #4536 is merged.

@mergify

This comment was marked as resolved.

@mergify

This comment was marked as resolved.

@mergify

This comment was marked as resolved.

@mergify

This comment was marked as resolved.

@mergify

This comment was marked as resolved.

@thomaseizinger thomaseizinger added the internal-change Pull requests that make internal changes to crates and thus don't need to include a changelog entry. label Oct 20, 2023
@thomaseizinger thomaseizinger marked this pull request as ready for review October 20, 2023 00:09
@thomaseizinger
Copy link
Contributor Author

Applying internal-change to avoid writing entries for all the crates that need to be updated because of this.

@mergify

This comment was marked as resolved.

@mergify

This comment was marked as resolved.

@mergify

This comment was marked as resolved.

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mergify mergify bot merged commit 1291ea9 into master Oct 24, 2023
71 checks passed
@mergify mergify bot deleted the feat/remove-poll-parameters branch October 24, 2023 17:28
umgefahren pushed a commit to umgefahren/rust-libp2p that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal-change Pull requests that make internal changes to crates and thus don't need to include a changelog entry. send-it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

swarm: Remove PollParameters
2 participants