Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(relay): delete now unused Action #4536

Merged
merged 3 commits into from
Sep 22, 2023
Merged

refactor(relay): delete now unused Action #4536

merged 3 commits into from
Sep 22, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

This is a relict from when we still had to delay the construction of ToSwarm commands because some data was only available in poll via PollParameters. This is now resolved and PollParameters will go away.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger added send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer. labels Sep 21, 2023
@thomaseizinger thomaseizinger mentioned this pull request Sep 21, 2023
Merged
4 tasks
@mergify mergify bot merged commit 32df6e8 into master Sep 22, 2023
69 checks passed
@mergify mergify bot deleted the refactor/simplify-relay branch September 22, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

Assignees
No one assigned
Labels
send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thomaseizinger