Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plaintext): rename symbols to follow naming convention #4535

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

thomaseizinger
Copy link
Contributor

@thomaseizinger thomaseizinger commented Sep 21, 2023

Description

Related: #2217.

Notes & open questions

I've recently worked with the plaintext protocol again as part of debugging the hole punching tests and thus noticed that we haven't renamed the symbols in that one yet.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mxinden
Copy link
Member

mxinden commented Sep 27, 2023

Retriggered flaky gossipsub test.

@mergify mergify bot merged commit fffd47b into master Sep 27, 2023
73 checks passed
@mergify mergify bot deleted the faet/rename-plaintext branch September 27, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants