Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: prepare non-breaking releases #4537

Merged
merged 4 commits into from
Sep 22, 2023
Merged

chore: prepare non-breaking releases #4537

merged 4 commits into from
Sep 22, 2023

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Sep 21, 2023 •
edited
Loading

Description

Crates to be released:

  • core
  • misc/futures-bounded
  • misc/server
  • misc/webrtc-utils
  • protocols/kad
  • protocols/ping
  • protocols/upnp
  • swarm
  • transports/webrtc-websys
  • transports/webrtc

Notes & open questions

@jxs given #4156

@mcamou given #4467 and #4466

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mxinden
chore: prepare non-breaking releases
45b33ea 
- core
- misc/futures-bounded
- misc/server
- misc/webrtc-utils
- protocols/kad
- protocols/ping
- protocols/upnp
- swarm
- transports/webrtc-websys
- transports/webrtc
@jxs
Copy link
Member

jxs commented Sep 21, 2023

Thanks for this Max! #4530 is also included

@divagant-martian divagant-martian mentioned this pull request Sep 21, 2023
Merged
4 tasks
thomaseizinger
thomaseizinger approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sounds good to me :)

I think we might want to do a few more point releases before the breaking one but there is no need to delay these further.

@mxinden mxinden mentioned this pull request Sep 22, 2023
Open
@mergify mergify bot merged commit 600b6af into libp2p:master Sep 22, 2023
72 of 73 checks passed
@mxinden
Copy link
Member Author

mxinden commented Sep 22, 2023

I think we might want to do a few more point releases before the breaking one

Got a particular non-breaking change in mind that you would like to release before tackling https://github.com/libp2p/rust-libp2p/milestone/7 @thomaseizinger?

@mxinden
Copy link
Member Author

mxinden commented Sep 22, 2023

Published and tagged the following crates:

  • futures-bounded-v0.1.0
  • libp2p-core-v0.40.1
  • libp2p-kad-v0.44.5
  • libp2p-ping-v0.43.1
  • libp2p-server-v0.12.3
  • libp2p-swarm-v0.43.4
  • libp2p-upnp-v0.1.0
  • libp2p-webrtc-utils-v0.1.0
  • libp2p-webrtc-v0.6.1-alpha
  • libp2p-webrtc-websys-v0.1.0-alpha

@thomaseizinger
Copy link
Contributor

I think we might want to do a few more point releases before the breaking one

Got a particular non-breaking change in mind that you would like to release before tackling https://github.com/libp2p/rust-libp2p/milestone/7 @thomaseizinger?

Let me have a closer look but I just want to make sure we don't miss certain deprecations for example for the upcoming breaking features :)

@thomaseizinger
Copy link
Contributor

I think we might want to do a few more point releases before the breaking one

Got a particular non-breaking change in mind that you would like to release before tackling libp2p/rust-libp2p/milestone/7 @thomaseizinger?

These are all ready-to-review, non-breaking changes that contain deprecations which would allow us to remove certain code sooner, i.e. with the next breaking release:

@thomaseizinger thomaseizinger mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxinden @jxs @thomaseizinger