Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare libp2p v0.52.4 #4625

Merged
merged 5 commits into from
Oct 18, 2023
Merged

chore: prepare libp2p v0.52.4 #4625

merged 5 commits into from
Oct 18, 2023

Conversation

jxs
Copy link
Member

@jxs jxs commented Oct 11, 2023

Description

Notes & open questions

Bug fixes to be included:

Best effort:

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we are now using workspace dependencies and given that we bumped libp2p-swarm but haven't yet released it, I think we need to do both in one go. In other words, we can not release libp2p-upnp v0.1.1, given that it would depend on an unreleased version of libp2p-swarm, namely v0.43.6. Or am I missing something?

https://github.com/libp2p/rust-libp2p/blob/master/swarm/CHANGELOG.md

@jxs
Copy link
Member Author

jxs commented Oct 12, 2023

No no Max, thanks for clarifying I wasn't aware, can we then also release libp2p-quic?
And I'll also prepare its release

@mxinden
Copy link
Member

mxinden commented Oct 12, 2023

Yes. Happy to do a large round of patch releases. Especially with #4120.

@jxs
Copy link
Member Author

jxs commented Oct 12, 2023

Ok thanks Max, updated :)

@mxinden
Copy link
Member

mxinden commented Oct 13, 2023

@thomaseizinger any objections to me cutting a full round of non-breaking releases?

@thomaseizinger
Copy link
Contributor

@thomaseizinger any objections to me cutting a full round of non-breaking releases?

Not at all :)

@thomaseizinger
Copy link
Contributor

@thomaseizinger any objections to me cutting a full round of non-breaking releases?

Before you do, can you please merge #4349 and include it there?

@jxs jxs changed the title chore(upnp): prepare v0.1.1 chore: prepare v0.1.1 Oct 16, 2023
@mxinden mxinden changed the title chore: prepare v0.1.1 chore: prepare libp2p v0.52.4 Oct 17, 2023
@mxinden
Copy link
Member

mxinden commented Oct 17, 2023

@jxs I updated title and description. The latter now links to the outstanding pull requests.

Everyone, please post here in case I am missing any other pull request.

@thomaseizinger
Copy link
Contributor

I just merged #4680 because it gives us a deprecation that we can then remove later and libp2p-swarm is to be released anyway.

@mergify mergify bot merged commit 014d735 into libp2p:master Oct 18, 2023
71 of 72 checks passed
@mxinden
Copy link
Member

mxinden commented Oct 18, 2023

Still releasing. Very slow. Assuming due to crate-ci/cargo-release#692.

@mxinden mxinden mentioned this pull request Oct 18, 2023
4 tasks
@mxinden
Copy link
Member

mxinden commented Oct 18, 2023

Published and tagged the following crates:

  • libp2p-deflate-v0.40.1
  • libp2p-dns-v0.40.1
  • libp2p-gossipsub-v0.45.2
  • libp2p-identify-v0.43.1
  • libp2p-identity-v0.2.7
  • libp2p-kad-v0.44.6
  • libp2p-noise-v0.43.2
  • libp2p-plaintext-v0.40.1
  • libp2p-pnet-v0.23.1
  • libp2p-quic-v0.9.3
  • libp2p-relay-v0.16.2
  • libp2p-rendezvous-v0.13.1
  • libp2p-request-response-v0.25.2
  • libp2p-swarm-v0.43.6
  • libp2p-tcp-v0.40.1
  • libp2p-upnp-v0.1.1
  • libp2p-v0.52.4
  • libp2p-webrtc-websys-v0.2.0-alpha
  • libp2p-websocket-websys-v0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants