-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare libp2p v0.52.4 #4625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we are now using workspace dependencies and given that we bumped libp2p-swarm
but haven't yet released it, I think we need to do both in one go. In other words, we can not release libp2p-upnp
v0.1.1
, given that it would depend on an unreleased version of libp2p-swarm
, namely v0.43.6
. Or am I missing something?
https://github.com/libp2p/rust-libp2p/blob/master/swarm/CHANGELOG.md
No no Max, thanks for clarifying I wasn't aware, can we then also release |
Yes. Happy to do a large round of patch releases. Especially with #4120. |
Ok thanks Max, updated :) |
@thomaseizinger any objections to me cutting a full round of non-breaking releases? |
Not at all :) |
Before you do, can you please merge #4349 and include it there? |
@jxs I updated title and description. The latter now links to the outstanding pull requests. Everyone, please post here in case I am missing any other pull request. |
I just merged #4680 because it gives us a deprecation that we can then remove later and |
Still releasing. Very slow. Assuming due to crate-ci/cargo-release#692. |
Published and tagged the following crates:
|
Description
Notes & open questions
Bug fixes to be included:
Best effort:
Config::set_connection_keep_alive
#4029Change checklist