Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(swarm): deprecated keep_alive_timeout from OneShotHandlerConfig #4680

Merged
merged 2 commits into from
Oct 17, 2023
Merged

feat(swarm): deprecated keep_alive_timeout from OneShotHandlerConfig #4680

merged 2 commits into from
Oct 17, 2023

Conversation

leonzchang
Copy link
Contributor

Description

Related: #3844.
Related: #4677

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@leonzchang leonzchang marked this pull request as ready for review October 17, 2023 11:09
@leonzchang leonzchang mentioned this pull request Oct 17, 2023
Merged
4 tasks
@leonzchang
Copy link
Contributor Author

Weird, multistream-select tests go well on the local.

@thomaseizinger
Copy link
Contributor

Weird, multistream-select tests go well on the local.

It is a rare flaky test unfortunately. I restarted it!

@mergify mergify bot merged commit 203e11c into libp2p:master Oct 17, 2023
72 checks passed
@thomaseizinger thomaseizinger mentioned this pull request Oct 17, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonzchang @thomaseizinger