Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(request-reponse): deprecate Config::set_connection_keep_alive #4678

Closed
wants to merge 2 commits into from
Closed

feat(request-reponse): deprecate Config::set_connection_keep_alive #4678

wants to merge 2 commits into from

Conversation

leonzchang
Copy link
Contributor

Description

Deprecate the request_reponse::Config::set_connection_keep_alive function in preparation for removing the KeepAlive::Until entirely..
Related: #3844.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@leonzchang leonzchang marked this pull request as ready for review October 17, 2023 09:41
@leonzchang leonzchang mentioned this pull request Oct 17, 2023
Merged
4 tasks
@thomaseizinger
Copy link
Contributor

We already have a PR for this bit :)

See #4029.

Going to close this as a duplicate. Thank you though!

@leonzchang
Copy link
Contributor Author

lol, didn't notice that XD

mergify bot pushed a commit that referenced this pull request Oct 20, 2023
@leonzchang
feat(request-response): remove Config::set_connection_keep_alive
79f961f 
This function has been deprecated and can now be removed.

Related: #3844.
Related: #4678.

Pull-Request: #4679.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonzchang @thomaseizinger