Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(request-response): remove Config::set_connection_keep_alive #4679

Merged
merged 11 commits into from
Oct 20, 2023
Merged

feat(request-response): remove Config::set_connection_keep_alive #4679

merged 11 commits into from
Oct 20, 2023

Conversation

leonzchang
Copy link
Contributor

@leonzchang leonzchang commented Oct 17, 2023 •
edited by thomaseizinger
Loading

Description

This function has been deprecated and can now be removed.

Related: #3844.
Related: #4678.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger mentioned this pull request Oct 17, 2023
Closed
thomaseizinger
thomaseizinger approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@thomaseizinger thomaseizinger added this to the v0.53.0 milestone Oct 17, 2023
@mergify

This comment was marked as resolved.

Sign in to view
@thomaseizinger thomaseizinger marked this pull request as ready for review October 20, 2023 01:16
@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2023

This pull request has merge conflicts. Could you please resolve them @leonzchang? 🙏

thomaseizinger
thomaseizinger reviewed Oct 20, 2023
View reviewed changes
Cargo.lock Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
thomaseizinger
thomaseizinger previously approved these changes Oct 20, 2023
View reviewed changes
@mergify mergify bot dismissed thomaseizinger’s stale review October 20, 2023 01:44

Approvals have been dismissed because the PR was updated after the send-it label was applied.

@thomaseizinger thomaseizinger changed the title feat(request-response): remove KeepAlive::Until feat(request-response): remove deprecated Config::set_connection_keep_alive Oct 20, 2023
@thomaseizinger thomaseizinger changed the title feat(request-response): remove deprecated Config::set_connection_keep_alive feat(request-response): remove Config::set_connection_keep_alive Oct 20, 2023
@thomaseizinger thomaseizinger added send-it internal-change Pull requests that make internal changes to crates and thus don't need to include a changelog entry. and removed send-it labels Oct 20, 2023
@mergify mergify bot merged commit 79f961f into libp2p:master Oct 20, 2023
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
internal-change Pull requests that make internal changes to crates and thus don't need to include a changelog entry. send-it
Projects
None yet
Milestone
v0.53.0
Development

Successfully merging this pull request may close these issues.
2 participants
@leonzchang @thomaseizinger