fix: rendezvous spec #284
Merged
fix: rendezvous spec #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thoughts @vyzo @jacobheun ? |
|
Yeah, let's just use signed peer records. |
vyzo
approved these changes
Jul 20, 2020
jacobheun
reviewed
Jul 20, 2020
rendezvous/README.md
Outdated
| @@ -204,6 +204,7 @@ message Message { | |||
| optional string ns = 1; | |||
| optional PeerInfo peer = 2; | |||
| optional int64 ttl = 3; // in seconds | |||
| optional bytes signedPeerRecord = 4; | |||
There was a problem hiding this comment.
Yeah, drop PeerInfo for signedPeerRecord. Also, this spec needs to point to the SignedPeerRecord spec to clarify what bytes signedPeerRecord actually is.
There was a problem hiding this comment.
Yeah, should we get the latest recommendations in and get the signed peer record PR merged? #217
vasco-santos
commented
Jul 21, 2020
jacobheun
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the SignedPeerRecord to the Register message.
Since this is still a Working Draft spec, there are a few things that I would like to suggest:
PeerInfomessage and just use theSignedPeerRecord